linux-kernel - RE: [PATCH V9 2/3] tty: serial: uartps: Relocate cdns_uart_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AS8PR05MB80870461086260FB60236B1D83752@AS8PR05MB8087.eurprd05.prod.outlook.com>
Date: Mon, 22 Jan 2024 16:49:00 +0000
From: Maarten Brock <Maarten.Brock@...ls.nl>
To: Manikanta Guntupalli <manikanta.guntupalli@....com>, "git@....com"
	<git@....com>, "michal.simek@....com" <michal.simek@....com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "linux-serial@...r.kernel.org"
	<linux-serial@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "jirislaby@...nel.org"
	<jirislaby@...nel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>
CC: "radhey.shyam.pandey@....com" <radhey.shyam.pandey@....com>,
	"srinivas.goud@....com" <srinivas.goud@....com>, "shubhrajyoti.datta@....com"
	<shubhrajyoti.datta@....com>, "manion05gk@...il.com" <manion05gk@...il.com>
Subject: RE: [PATCH V9 2/3] tty: serial: uartps: Relocate cdns_uart_tx_empty
 to facilitate rs485

> -----Original Message-----
> From: Manikanta Guntupalli <manikanta.guntupalli@....com>
> Sent: Thursday, 18 January 2024 08:40
> Subject: [PATCH V9 2/3] tty: serial: uartps: Relocate cdns_uart_tx_empty to
> facilitate rs485
> 
> Relocate cdns_uart_tx_empty function to avoid prototype statement in
> rs485 changes.
> Update return check with uart_tx_stopped() in cdns_uart_handle_tx().
> 
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@....com>
> ---
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -316,7 +331,7 @@ static void cdns_uart_handle_tx(void *dev_id)
>  	struct circ_buf *xmit = &port->state->xmit;
>  	unsigned int numbytes;
> 
> -	if (uart_circ_empty(xmit)) {
> +	if (uart_circ_empty(xmit) || uart_tx_stopped(port)) {

Can you please also insert a comment here?
+ 		/* Disable the TX Empty interrupt */

>  		writel(CDNS_UART_IXR_TXEMPTY, port->membase +
> CDNS_UART_IDR);
>  		return;
>  	}
 
Kind regards,
Maarten Brock