linux-kernel - Re: [PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23373359.6Emhk5qWAg@radijator>
Date: Mon, 22 Jan 2024 17:57:53 +0100
From: Duje Mihanović <duje.mihanovic@...le.hr>
To: Daniel Thompson <daniel.thompson@...aro.org>
Cc: Lee Jones <lee@...nel.org>, Jingoo Han <jingoohan1@...il.com>,
 Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Helge Deller <deller@....de>,
 Linus Walleij <linus.walleij@...aro.org>, Karel Balej <balejk@...fyz.cz>,
 ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linux-leds@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-fbdev@...r.kernel.org
Subject: Re: [PATCH v3 1/3] leds: ktd2692: move ExpressWire code to library

On Monday, January 22, 2024 5:50:11 PM CET Daniel Thompson wrote:
> On Mon, Jan 22, 2024 at 05:24:51PM +0100, Duje Mihanović wrote:
> > I believe a "select" would be more appropriate here unless these 
backlights
> > should be hidden if GPIOLIB is disabled. The catch with "select" is that
> > there seems to be no way to throw in the "|| COMPILE_TEST" other GPIO-
based
> > backlights have and I'm not sure what to do about that.
> 
> I think the "|| COMPILE_TEST" might just be a copy 'n paste'ism (in fact I
> may even have been guilty off propagating it in reviews when checking
> for inconsistencies).
> 
> AFAICT nothing will inhibit setting GPIOLIB so allyes- and allmodconfig
> builds will always end up with GPIOLIB enabled. If we are happy to
> select it then I think that is enough!

In that case I guess I'll just make it select GPIOLIB.

Regards,
--
Duje