linux-kernel - Re: [PATCH] drm/dp_mst: Separate @failing_port list in drm_dp_mst_atomic_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87r0i9nv1s.fsf@intel.com>
Date: Mon, 22 Jan 2024 19:21:19 +0200
From: Jani Nikula <jani.nikula@...el.com>
To: Bagas Sanjaya <bagasdotme@...il.com>, Linux Kernel Mailing List
 <linux-kernel@...r.kernel.org>, Linux Documentation
 <linux-doc@...r.kernel.org>, Linux DRI Development
 <dri-devel@...ts.freedesktop.org>, Linux Intel Graphics
 <intel-gfx@...ts.freedesktop.org>
Cc: David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, Lyude
 Paul <lyude@...hat.com>, Imre Deak <imre.deak@...el.com>, Wayne Lin
 <Wayne.Lin@....com>, Maxime Ripard <mripard@...nel.org>, Ville
 Syrjälä
 <ville.syrjala@...ux.intel.com>, Joonas Lahtinen
 <joonas.lahtinen@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>,
 Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>, Bagas Sanjaya
 <bagasdotme@...il.com>, Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] drm/dp_mst: Separate @failing_port list in
 drm_dp_mst_atomic_check_mgr() comment

On Tue, 14 Nov 2023, Bagas Sanjaya <bagasdotme@...il.com> wrote:
> Stephen Rothwell reported htmldocs warnings when merging drm-intel
> tree:
>
> Documentation/gpu/drm-kms-helpers:296: drivers/gpu/drm/display/drm_dp_mst_topology.c:5484: ERROR: Unexpected indentation.
> Documentation/gpu/drm-kms-helpers:296: drivers/gpu/drm/display/drm_dp_mst_topology.c:5488: WARNING: Block quote ends without a blank line; unexpected unindent.
>
> Separate @failing_port return value list by surrounding it with a
> blank line to fix above warnings.
>
> Fixes: 1cd0a5ea427931 ("drm/dp_mst: Factor out a helper to check the atomic state of a topology manager")
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Closes: https://lore.kernel.org/linux-next/20231114141715.6f435118@canb.auug.org.au/
> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>

Thanks, pushed to drm-misc-fixes.

BR,
Jani.

> ---
>  drivers/gpu/drm/display/drm_dp_mst_topology.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> index 0854fe428f173a..b9a98587fbef7f 100644
> --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> @@ -5479,6 +5479,7 @@ EXPORT_SYMBOL(drm_dp_mst_atomic_enable_dsc);
>   *   - 0 if the new state is valid
>   *   - %-ENOSPC, if the new state is invalid, because of BW limitation
>   *         @failing_port is set to:
> + *
>   *         - The non-root port where a BW limit check failed
>   *           with all the ports downstream of @failing_port passing
>   *           the BW limit check.
> @@ -5487,6 +5488,7 @@ EXPORT_SYMBOL(drm_dp_mst_atomic_enable_dsc);
>   *         - %NULL if the BW limit check failed at the root port
>   *           with all the ports downstream of the root port passing
>   *           the BW limit check.
> + *
>   *   - %-EINVAL, if the new state is invalid, because the root port has
>   *     too many payloads.
>   */
>
> base-commit: 59be90248b422f2924872de0be2867652214096a

-- 
Jani Nikula, Intel