linux-kernel - Re: [PATCH v6 1/3] kselftests: lib.mk: Add TEST_GEN_MODS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 22 Jan 2024 14:37:09 -0300
From: Marcos Paulo de Souza <mpdesouza@...e.com>
To: Shuah Khan <skhan@...uxfoundation.org>, Shuah Khan <shuah@...nel.org>, 
 Jonathan Corbet <corbet@....net>, Heiko Carstens <hca@...ux.ibm.com>,
 Vasily Gorbik <gor@...ux.ibm.com>, Alexander Gordeev
 <agordeev@...ux.ibm.com>, Christian Borntraeger
 <borntraeger@...ux.ibm.com>, Sven Schnelle <svens@...ux.ibm.com>, Josh
 Poimboeuf <jpoimboe@...nel.org>, Jiri Kosina <jikos@...nel.org>, Miroslav
 Benes <mbenes@...e.cz>, Petr Mladek <pmladek@...e.com>, Joe Lawrence
 <joe.lawrence@...hat.com>
Cc: linux-kselftest@...r.kernel.org, linux-doc@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org, 
	live-patching@...r.kernel.org
Subject: Re: [PATCH v6 1/3] kselftests: lib.mk: Add TEST_GEN_MODS_DIR
 variable

On Mon, 2024-01-22 at 10:15 -0700, Shuah Khan wrote:
> On 1/12/24 10:43, Marcos Paulo de Souza wrote:
> > Add TEST_GEN_MODS_DIR variable for kselftests. It can point to
> > a directory containing kernel modules that will be used by
> > selftest scripts.
> > 
> > The modules are built as external modules for the running kernel.
> > As a result they are always binary compatible and the same tests
> > can be used for older or newer kernels.
> > 
> > The build requires "kernel-devel" package to be installed.
> > For example, in the upstream sources, the rpm devel package
> > is produced by "make rpm-pkg"
> > 
> > The modules can be built independently by
> > 
> >    make -C tools/testing/selftests/livepatch/
> > 
> > or they will be automatically built before running the tests via
> > 
> >    make -C tools/testing/selftests/livepatch/ run_tests
> > 
> > Note that they are _not_ built when running the standalone
> > tests by calling, for example, ./test-state.sh.
> > 
> > Along with TEST_GEN_MODS_DIR, it was necessary to create a new
> > install
> > rule. INSTALL_MODS_RULE is needed because INSTALL_SINGLE_RULE would
> > copy the entire TEST_GEN_MODS_DIR directory to the destination,
> > even
> > the files created by Kbuild to compile the modules. The new install
> > rule copies only the .ko files, as we would expect the gen_tar to
> > work.
> > 
> > Reviewed-by: Joe Lawrence <joe.lawrence@...hat.com>
> > Reviewed-by: Petr Mladek <pmladek@...e.com>
> > Signed-off-by: Marcos Paulo de Souza <mpdesouza@...e.com>
> > ---
> >   Documentation/dev-tools/kselftest.rst |  4 ++++
> >   tools/testing/selftests/lib.mk        | 26 +++++++++++++++++++++-
> > ----
> 
> 
> Hi Marcos,
> 
> I would like the doc patch and lib.mk patch separate. If lib.mk needs
> changes
> we don't have to touch the doc patch.

Hi Shuah,
on patch 2/3 you also said that you would like to have the
documentation changes split in the future, and that you picked the
changes into a testing branch. Does it also applies to this patch?

Do I need to resend the three patches and separate the documentation
part into a new one, or can I apply this rationale to future changes to
lib.mk? Sorry, I'm confused.

Thanks in advance,
  Marcos

> 
> thanks,
> -- Shuah