linux-kernel - Re: [GIT PULL] SPI updates for v6.8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 22 Jan 2024 19:30:09 +0100
From: Klaus Kudielka <klaus.kudielka@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] SPI updates for v6.8

On Sun, 2024-01-07 at 22:38 +0000, Mark Brown wrote:
> The following changes since commit 2cc14f52aeb78ce3f29677c2de1f06c0e91471ab:
> 
>   Linux 6.7-rc3 (2023-11-26 19:59:33 -0800)
> 
> are available in the Git repository at:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git tags/spi-v6.8
> 
> for you to fetch changes up to f6cd66231aa58599526584ff4df1bdde8d86eac8:
> 
>   spi: stm32: add st,stm32mp25-spi compatible supporting STM32MP25 soc (2023-12-21 20:44:05 +0000)
> 
> ----------------------------------------------------------------
> spi: Updates for v6.8
> 
> A moderately busy release for SPI, the main core update was the merging
> of support for multiple chip selects, used in some flash configurations.
> There were also big overhauls for the AXI SPI Engine and PL022 drivers,
> plus some new device support for ST.
> 
> There's a few patches for other trees, API updates to allow the
> multiple chip select support and one of the naming modernisations
> touched a controller embedded in the USB code.
> 
>  - Support for multiple chip selects.

[skipped the rest]

Hi, it seems I have an issue related with this new feature.

I just booted 6.8.0-rc1 on Turris Omnia (CONFIG_SPI_ORION=y,
device tree: arch/arm/boot/dts/marvell/armada-385-turris-omnia.dts)

and got the following error:

[    0.090231] spi_master spi0: No. of CS is more than max. no. of supported CS
[    0.097358] spi_master spi0: Failed to create SPI device for /soc/spi@...00/flash@0

End result: the three MTD partitions I used to have on the SPI-NOR are gone.

***

For reference, here's the output of 6.7.0 (configs as identical as they can be):

[    0.087965] spi-nor spi0.0: s25fl164k (8192 Kbytes)
[    0.183729] Freeing initrd memory: 4676K
[    0.191605] 3 fixed-partitions partitions found on MTD device spi0.0
[    0.191619] Creating 3 MTD partitions on "spi0.0":
[    0.191624] 0x000000000000-0x0000000f0000 : "U-Boot"
[    0.191837] 0x000000100000-0x000000800000 : "Rescue system"
[    0.191982] 0x0000000f0000-0x000000100000 : "u-boot-env"


I haven't bisected this further, but maybe the error message already rings a bell.


Best regards, Klaus