linux-kernel - Re: [PATCH net-next 04/22] net: fill in MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 22 Jan 2024 11:01:44 -0800
From: Breno Leitao <leitao@...ian.org>
To: Florian Fainelli <florian.fainelli@...adcom.com>
Cc: kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com,
	Rafał Miłecki <rafal@...ecki.pl>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Paolo Abeni <pabeni@...hat.com>, dsahern@...nel.org,
	weiwan@...gle.com,
	"open list:BROADCOM BCM4908 ETHERNET DRIVER" <netdev@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 04/22] net: fill in MODULE_DESCRIPTION()s for
 Broadcom bgmac

On Mon, Jan 22, 2024 at 10:50:32AM -0800, Florian Fainelli wrote:
> On 1/22/24 10:45, Breno Leitao wrote:
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to the Broadcom iProc GBit driver.
> > 
> > Signed-off-by: Breno Leitao <leitao@...ian.org>
> > ---
> >   drivers/net/ethernet/broadcom/bcm4908_enet.c    | 1 +
> >   drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c | 1 +
> >   drivers/net/ethernet/broadcom/bgmac-bcma.c      | 1 +
> >   drivers/net/ethernet/broadcom/bgmac-platform.c  | 1 +
> >   drivers/net/ethernet/broadcom/bgmac.c           | 1 +
> >   5 files changed, 5 insertions(+)
> > 
> > diff --git a/drivers/net/ethernet/broadcom/bcm4908_enet.c b/drivers/net/ethernet/broadcom/bcm4908_enet.c
> > index 3e7c8671cd11..a6bc5ce70230 100644
> > --- a/drivers/net/ethernet/broadcom/bcm4908_enet.c
> > +++ b/drivers/net/ethernet/broadcom/bcm4908_enet.c
> > @@ -793,5 +793,6 @@ static struct platform_driver bcm4908_enet_driver = {
> >   };
> >   module_platform_driver(bcm4908_enet_driver);
> > +MODULE_DESCRIPTION("Broadcom iProc GBit Ethernet driver");
> 
> This should be:
> 
> Broadcom BCM4908 Gigabit Ethernet driver

Thanks. I will update in v2.