linux-kernel - Re: [PATCH net-next 16/22] net: fill in MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 22 Jan 2024 12:35:02 -0700
From: "Subash Abhinov Kasiviswanathan (KS)" <quic_subashab@...cinc.com>
To: Breno Leitao <leitao@...ian.org>, <kuba@...nel.org>, <davem@...emloft.net>,
        <abeni@...hat.com>, <edumazet@...gle.com>,
        Timur Tabi
	<timur@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
        Sean Tranchetti
	<quic_stranche@...cinc.com>
CC: <dsahern@...nel.org>, <weiwan@...gle.com>,
        "open list:QUALCOMM EMAC
 GIGABIT ETHERNET DRIVER" <netdev@...r.kernel.org>,
        open list
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 16/22] net: fill in MODULE_DESCRIPTION()s for
 Qualcom drivers


On 1/22/2024 11:45 AM, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the Qualcom rmnet and emac drivers.
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>
> ---
>   drivers/net/ethernet/qualcomm/emac/emac.c          | 1 +
>   drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/qualcomm/emac/emac.c b/drivers/net/ethernet/qualcomm/emac/emac.c
> index 3270df72541b..4c06f55878de 100644
> --- a/drivers/net/ethernet/qualcomm/emac/emac.c
> +++ b/drivers/net/ethernet/qualcomm/emac/emac.c
> @@ -771,5 +771,6 @@ static struct platform_driver emac_platform_driver = {
>   
>   module_platform_driver(emac_platform_driver);
>   
> +MODULE_DESCRIPTION("Qualcomm EMAC Gigabit Ethernet driver");
>   MODULE_LICENSE("GPL v2");
>   MODULE_ALIAS("platform:qcom-emac");
> diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
> index 5b69b9268c75..f3bea196a8f9 100644
> --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
> +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c
> @@ -520,4 +520,5 @@ static void __exit rmnet_exit(void)
>   module_init(rmnet_init)
>   module_exit(rmnet_exit)
>   MODULE_ALIAS_RTNL_LINK("rmnet");
> +MODULE_DESCRIPTION("Qualcomm RmNet MAP driver");
>   MODULE_LICENSE("GPL v2");

For rmnet

Reviewed-by: Subash Abhinov Kasiviswanathan <quic_subashab@...cinc.com>