| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <00232392-dc40-4790-9278-91df30e50a04@gmx.de> Date: Mon, 22 Jan 2024 21:00:58 +0100 From: Helge Deller <deller@....de> To: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>, gregkh@...uxfoundation.org Cc: linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org, Daniel Vetter <daniel@...ll.ch>, dri-devel@...ts.freedesktop.org, "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>, Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org, linux-fbdev@...r.kernel.org, linux-parisc@...r.kernel.org, Martin Hostettler <textshell@...uujin.de>, Thomas Zimmermann <tzimmermann@...e.de> Subject: Re: [PATCH v2 00/47] tty: vt: cleanup and documentation On 1/22/24 12:03, Jiri Slaby (SUSE) wrote: > Push the console code (vt.c, vt.h, console.h, ...) into a bit more > maintainable state. Especially all around consw structure and document > it. > > CSI parser is also a bit cleaned up. More to follow some time in the > next round. I've not yet looked through all of those patches, but I tried to boot up a machine with the STI console driver and I've not seen any issues yet. So far: Tested-by: Helge Deller <deller@....de> # parisc STI console Helge > [v2] See respective patches for changes. The major changes: > * vesa.h introduced > * parameters of csi*() simplified > > Cc: Daniel Vetter <daniel@...ll.ch> > Cc: dri-devel@...ts.freedesktop.org > Cc: Helge Deller <deller@....de> > Cc: "James E.J. Bottomley" <James.Bottomley@...senPartnership.com> > Cc: Jonathan Corbet <corbet@....net> > Cc: linux-doc@...r.kernel.org > Cc: linux-fbdev@...r.kernel.org > Cc: linux-parisc@...r.kernel.org > Cc: Martin Hostettler <textshell@...uujin.de> > Cc: Thomas Zimmermann <tzimmermann@...e.de> > > Jiri Slaby (SUSE) (47): > > vgacon: inline vc_scrolldelta_helper() into vgacon_scrolldelta() > fbcon: make display_desc a static array in fbcon_startup() > tty: vt: fix 20 vs 0x20 typo in EScsiignore > tty: vt: expect valid vc when in tty ops > tty: vt: pass proper pointers from tioclinux() > tty: vt: push console lock from tioclinux() down to 2 functions > tty: vt: pass vc_resize_user as a parameter > tty: vt: make vc_is_sel()'s vc const > tty: vt: define an enum for CSI+m codes > tty: vt: use case ranges for CSI+m fg/bg colors > tty: vt: define an enum for CSI+J codes > tty: vt: reflow csi_J() > use clamp() for counts in csi_?() handlers > don't pass vc->vc_par[0] to csi_?() handlers > tty: vt: define an enum for CSI+K codes > tty: vt: reflow csi_K() > tty: vt: define an enum for ascii characters > tty: vt: remove extern from functions in selection.h > tty: vt: make consw::con_debug_*() return void > tty: vt: make init parameter of consw::con_init() a bool > tty: vt: sanitize arguments of consw::con_clear() > tty: vt: remove checks for count in consw::con_clear() implementations > tty: vt: add con_putc() helper > tty: vt: eliminate unneeded consw::con_putc() implementations > tty: vt: sanitize consw::con_putc() parameters > tty: vt: sanitize consw::con_putcs() parameters > consoles: use if instead of switch-case in consw::con_cursor() > fbdev/core: simplify cursor_state setting in fbcon_ops::cursor() > tty: vt: remove CM_* constants > tty: vt: make consw::con_switch() return a bool > tty: vt: stop using -1 for blank mode in consw::con_blank() > tty: vt: define a common enum for VESA blanking constants > tty: vt: use VESA blanking constants > tty: vt: use enum constants for VESA blanking modes > tty: vt: make types around consw::con_blank() bool > tty: vt: make font of consw::con_font_set() const > tty: vt: make consw::con_font_default()'s name const > tty: vt: change consw::con_set_origin() return type > fbcon: remove consw::con_screen_pos() > tty: vt: remove consw::con_screen_pos() > tty: vt: make types of screenpos() more consistent > fbcon: remove fbcon_getxy() > tty: vt: remove consw::con_getxy() > tty: vt: remove unused consw::con_flush_scrollback() > tty: vt: document the rest of struct consw > tty: vt: fix up kernel-doc > Documentation: add console.rst > > Documentation/driver-api/tty/console.rst | 45 ++ > Documentation/driver-api/tty/index.rst | 1 + > drivers/tty/vt/selection.c | 43 +- > drivers/tty/vt/vt.c | 645 +++++++++++------------ > drivers/tty/vt/vt_ioctl.c | 6 +- > drivers/video/console/dummycon.c | 38 +- > drivers/video/console/mdacon.c | 43 +- > drivers/video/console/newport_con.c | 69 +-- > drivers/video/console/sticon.c | 79 ++- > drivers/video/console/vgacon.c | 152 +++--- > drivers/video/fbdev/core/bitblit.c | 13 +- > drivers/video/fbdev/core/fbcon.c | 123 ++--- > drivers/video/fbdev/core/fbcon.h | 4 +- > drivers/video/fbdev/core/fbcon_ccw.c | 13 +- > drivers/video/fbdev/core/fbcon_cw.c | 13 +- > drivers/video/fbdev/core/fbcon_ud.c | 13 +- > drivers/video/fbdev/core/tileblit.c | 4 +- > include/linux/console.h | 124 +++-- > include/linux/console_struct.h | 1 - > include/linux/selection.h | 56 +- > include/linux/vt_kern.h | 12 +- > include/uapi/linux/fb.h | 8 +- > include/uapi/linux/vesa.h | 18 + > 23 files changed, 755 insertions(+), 768 deletions(-) > create mode 100644 Documentation/driver-api/tty/console.rst > create mode 100644 include/uapi/linux/vesa.h >
Powered by blists - more mailing lists