[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240122205738.2432552-1-charles.perry@savoirfairelinux.com>
Date: Mon, 22 Jan 2024 15:57:29 -0500
From: Charles Perry <charles.perry@...oirfairelinux.com>
To: shawnguo@...nel.org
Cc: robh@...nel.org,
linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org,
charles.perry@...oirfairelinux.com
Subject: [PATCH] bus: imx-weim: fix imx_weim_gpr_setup()
Commit 2a88e4792c6d ("bus: imx-weim: Remove open coded "ranges"
parsing") changes the parsing of the "ranges" field by using
for_each_of_range instead of of_property_for_each_u32. The number of
iteration of the loop is now equal to the number of range within
ranges. It is therefore no longer needed to check that i is divisible
by 4, otherwise, valid configurations will fail imx_weim_gpr_setup().
Fixes: 2a88e4792c6d ("bus: imx-weim: Remove open coded "ranges" parsing")
Signed-off-by: Charles Perry <charles.perry@...oirfairelinux.com>
---
drivers/bus/imx-weim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 6b5da73c85417..837bf9d51c6ec 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -120,7 +120,7 @@ static int imx_weim_gpr_setup(struct platform_device *pdev)
i++;
}
- if (i == 0 || i % 4)
+ if (i == 0)
goto err;
for (i = 0; i < ARRAY_SIZE(gprvals); i++) {
--
2.43.0
Powered by blists - more mailing lists