linux-kernel - Re: [PATCH v2 1/2] kselftest/seccomp: Use kselftest output functions for benchmark

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202401221331.313C61FDB0@keescook>
Date: Mon, 22 Jan 2024 13:31:34 -0800
From: Kees Cook <keescook@...omium.org>
To: Mark Brown <broonie@...nel.org>
Cc: Andy Lutomirski <luto@...capital.net>, Will Drewry <wad@...omium.org>,
	Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Anders Roxell <anders.roxell@...aro.org>
Subject: Re: [PATCH v2 1/2] kselftest/seccomp: Use kselftest output functions
 for benchmark

On Mon, Jan 22, 2024 at 04:04:15PM +0000, Mark Brown wrote:
> In preparation for trying to output the test results themselves in TAP
> format rework all the prints in the benchmark to use the kselftest output
> functions. The uses of system() all produce single line output so we can
> avoid having to deal with fully managing the child process and continue to
> use system() by simply printing an empty message before we invoke system().
> We also leave one printf() used to complete a line of output in place.
> 
> Tested-by: Anders Roxell <anders.roxell@...aro.org>
> Signed-off-by: Mark Brown <broonie@...nel.org>

Acked-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook