linux-kernel - Re: [PATCH bpf-next v6 2/3] selftests/bpf: Copy insn_is_pseudo_func() into testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW7QpiUTaqRp=mnWvxCY_mSeuaFpiY4G9OdAZBZ6RmnPBg@mail.gmail.com>
Date: Mon, 22 Jan 2024 14:59:46 -0800
From: Song Liu <song@...nel.org>
To: Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc: Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, 
	Andrii Nakryiko <andrii@...nel.org>, Eduard Zingerman <eddyz87@...il.com>, 
	John Fastabend <john.fastabend@...il.com>, Jiri Olsa <jolsa@...nel.org>, 
	Hou Tao <houtao@...weicloud.com>, bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next v6 2/3] selftests/bpf: Copy insn_is_pseudo_func()
 into testing_helpers

On Sun, Jan 21, 2024 at 11:57 PM Tiezhu Yang <yangtiezhu@...ngson.cn> wrote:
>
> insn_is_pseudo_func() will be used in test_verifier, the original idea is
> to move it from libbpf.c to libbpf_internal.h and then include the header
> to reuse this function, this just adds more internal code of libbpf used
> by selftests. While we have allowed it in some cases to avoid duplication
> of more complex logic, it is not justified in this case.
>
> Since insn_is_pseudo_func() and its helper is_ldimm64_insn() are trivial
> enough, just copy into testing_helpers.
>
> Suggested-by: Andrii Nakryiko <andrii@...nel.org>
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>

Acked-by: Song Liu <song@...nel.org>