linux-kernel - Re: [PATCH 1/3] Input: matrix_keypad - avoid repeatedly converting GPIO to IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 22 Jan 2024 09:19:56 +0100
From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: linux-input@...r.kernel.org, Dan Carpenter <dan.carpenter@...aro.org>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] Input: matrix_keypad - avoid repeatedly converting
 GPIO to IRQ

On Sun, 21 Jan 2024 at 06:32, Dmitry Torokhov <dmitry.torokhov@...il.com> wrote:
>
> gpio_to_irq() is getting more expensive and may require sleeping.

This is no longer true, the relevant commit was reverted and I have
now a working series where I'm using SRCU for lockless list traversal
so if anything it will actually become cheaper.

> Convert row GPIOs to interrupt numbers once in probe() and use
> this information when the driver needs to enable or disable given
> interrupt line.

That being said, I'm not against this change, though this may not be
very useful after all.

Bartosz

[snip!]