lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <Za4oN9MBgdI3jTGz@rli9-mobl>
Date: Mon, 22 Jan 2024 16:32:55 +0800
From: kernel test robot <lkp@...el.com>
To: Samuel Holland <samuel@...lland.org>
CC: <oe-kbuild-all@...ts.linux.dev>, <linux-kernel@...r.kernel.org>, "Jernej
 Skrabec" <jernej.skrabec@...il.com>, Guo Ren <guoren@...nel.org>, "Heiko
 Stuebner" <heiko@...ech.de>
Subject: drivers/clk/sunxi/clk-a20-gmac.c:43: warning: expecting prototype
 for sun7i_a20_gmac_clk_setup(). Prototype was for SUN7I_A20_GMAC_GPIT()
 instead

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   0cb552aa97843f24549ce808883494138471c16b
commit: 6f5178acf63614f2ee27450b2ab4d4980a698161 riscv: Add the Allwinner SoC family Kconfig option
date:   12 months ago
:::::: branch date: 3 hours ago
:::::: commit date: 12 months ago
config: riscv-randconfig-r042-20230805 (https://download.01.org/0day-ci/archive/20240111/202401110628.T2xYEQhh-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20240111/202401110628.T2xYEQhh-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/r/202401110628.T2xYEQhh-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/clk/sunxi/clk-a20-gmac.c:43: warning: expecting prototype for sun7i_a20_gmac_clk_setup(). Prototype was for SUN7I_A20_GMAC_GPIT() instead
--
>> drivers/clk/sunxi/clk-usb.c:80: warning: expecting prototype for sunxi_usb_clk_setup(). Prototype was for SUNXI_USB_MAX_SIZE() instead
--
>> drivers/clk/sunxi/clk-sun9i-cpus.c:25: warning: expecting prototype for sun9i_a80_cpus_clk_setup(). Prototype was for SUN9I_CPUS_MAX_PARENTS() instead


vim +43 drivers/clk/sunxi/clk-a20-gmac.c

59cb10e32a6053 Maxime Ripard 2014-05-09  17  
59cb10e32a6053 Maxime Ripard 2014-05-09  18  /**
59cb10e32a6053 Maxime Ripard 2014-05-09  19   * sun7i_a20_gmac_clk_setup - Setup function for A20/A31 GMAC clock module
59cb10e32a6053 Maxime Ripard 2014-05-09  20   *
59cb10e32a6053 Maxime Ripard 2014-05-09  21   * This clock looks something like this
59cb10e32a6053 Maxime Ripard 2014-05-09  22   *                               ________________________
59cb10e32a6053 Maxime Ripard 2014-05-09  23   *  MII TX clock from PHY >-----|___________    _________|----> to GMAC core
59cb10e32a6053 Maxime Ripard 2014-05-09  24   *  GMAC Int. RGMII TX clk >----|___________\__/__gate---|----> to PHY
59cb10e32a6053 Maxime Ripard 2014-05-09  25   *  Ext. 125MHz RGMII TX clk >--|__divider__/            |
59cb10e32a6053 Maxime Ripard 2014-05-09  26   *                              |________________________|
59cb10e32a6053 Maxime Ripard 2014-05-09  27   *
59cb10e32a6053 Maxime Ripard 2014-05-09  28   * The external 125 MHz reference is optional, i.e. GMAC can use its
59cb10e32a6053 Maxime Ripard 2014-05-09  29   * internal TX clock just fine. The A31 GMAC clock module does not have
59cb10e32a6053 Maxime Ripard 2014-05-09  30   * the divider controls for the external reference.
59cb10e32a6053 Maxime Ripard 2014-05-09  31   *
59cb10e32a6053 Maxime Ripard 2014-05-09  32   * To keep it simple, let the GMAC use either the MII TX clock for MII mode,
59cb10e32a6053 Maxime Ripard 2014-05-09  33   * and its internal TX clock for GMII and RGMII modes. The GMAC driver should
59cb10e32a6053 Maxime Ripard 2014-05-09  34   * select the appropriate source and gate/ungate the output to the PHY.
59cb10e32a6053 Maxime Ripard 2014-05-09  35   *
59cb10e32a6053 Maxime Ripard 2014-05-09  36   * Only the GMAC should use this clock. Altering the clock so that it doesn't
59cb10e32a6053 Maxime Ripard 2014-05-09  37   * match the GMAC's operation parameters will result in the GMAC not being
59cb10e32a6053 Maxime Ripard 2014-05-09  38   * able to send traffic out. The GMAC driver should set the clock rate and
59cb10e32a6053 Maxime Ripard 2014-05-09  39   * enable/disable this clock to configure the required state. The clock
59cb10e32a6053 Maxime Ripard 2014-05-09  40   * driver then responds by auto-reparenting the clock.
59cb10e32a6053 Maxime Ripard 2014-05-09  41   */
59cb10e32a6053 Maxime Ripard 2014-05-09  42  
59cb10e32a6053 Maxime Ripard 2014-05-09 @43  #define SUN7I_A20_GMAC_GPIT	2
59cb10e32a6053 Maxime Ripard 2014-05-09  44  #define SUN7I_A20_GMAC_MASK	0x3
59cb10e32a6053 Maxime Ripard 2014-05-09  45  #define SUN7I_A20_GMAC_PARENTS	2
59cb10e32a6053 Maxime Ripard 2014-05-09  46  

:::::: The code at line 43 was first introduced by commit
:::::: 59cb10e32a60533865e26dc9a8303306ba972a70 clk: sunxi: Move the GMAC clock to a file of its own

:::::: TO: Maxime Ripard <maxime.ripard@...e-electrons.com>
:::::: CC: Maxime Ripard <maxime.ripard@...e-electrons.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ