[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240122-jawline-handling-e190c90ddcfc@spud>
Date: Mon, 22 Jan 2024 08:55:11 +0000
From: Conor Dooley <conor@...nel.org>
To: yunhui cui <cuiyunhui@...edance.com>
Cc: paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu,
conor.dooley@...rochip.com, robh@...nel.org, sudeep.holla@....com,
pierre.gondois@....com, suagrfillet@...il.com,
linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [External] Re: [PATCH] RISC-V: cacheinfo: add init_cache_level()
On Mon, Jan 22, 2024 at 04:32:15PM +0800, yunhui cui wrote:
> Hi Conor,
>
> On Mon, Jan 22, 2024 at 4:09 PM Conor Dooley <conor@...nel.org> wrote:
> >
> > On Mon, Jan 22, 2024 at 09:35:10AM +0800, Yunhui Cui wrote:
> > > When cacheinfo_sysfs_init() is executed, the general weak function
> > > init_cache_level() returns -ENOENT, causing failure to add the "cache"
> > > node to /sys/devices/system/cpu/cpux/. Implement the init_cache_level()
> > > function on RISC-V to fix it.
> >
> > If you recall correctly, I asked you to explain how to reproduce this
> > when you sent the patch.
>
> In fact, the reason has been explained in the commit log. As for how
> to reproduce it, you can check whether there is a "cache" node in
> /sys/devices/system/cpu/cpux/ on the riscv platform.
That's the thing - I tried to reproduce this several times and either:
a) The system had cache information in DT and the directory was
created. If I hot unplugged and re-plugged the directory was
re-created.
b) The system had no cache information in DT and the directory was never
created.
You said in your original report that you came across this problem in
qemu - can you share the qemu command required to reproduce please?
Thanks,
Conor.
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists