linux-kernel - RE: [RFCv2 PATCH 7/7] iommu/amd: Add nested domain attach/detach support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB52769DA43BC124BF3ED255018C752@BN9PR11MB5276.namprd11.prod.outlook.com>
Date: Mon, 22 Jan 2024 08:56:42 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Suravee Suthikulpanit <suravee.suthikulpanit@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"iommu@...ts.linux.dev" <iommu@...ts.linux.dev>, "joro@...tes.org"
	<joro@...tes.org>, "jgg@...dia.com" <jgg@...dia.com>
CC: "Liu, Yi L" <yi.l.liu@...el.com>, "nicolinc@...dia.com"
	<nicolinc@...dia.com>, "eric.auger@...hat.com" <eric.auger@...hat.com>,
	"vasant.hegde@....com" <vasant.hegde@....com>, "jon.grimm@....com"
	<jon.grimm@....com>, "santosh.shukla@....com" <santosh.shukla@....com>,
	"Dhaval.Giani@....com" <Dhaval.Giani@....com>, "pandoh@...gle.com"
	<pandoh@...gle.com>, "loganodell@...gle.com" <loganodell@...gle.com>
Subject: RE: [RFCv2 PATCH 7/7] iommu/amd: Add nested domain attach/detach
 support

> From: Suravee Suthikulpanit <suravee.suthikulpanit@....com>
> Sent: Friday, January 12, 2024 8:07 AM
> 
> 
> -	/* Use system default */
> -	tmp = amd_iommu_gpt_level;
> +	if (amd_iommu_domain_is_nested(pdom)) {
> +		/*
> +		 * For nested domain, guest provide guest-paging mode.
> +		 * We need to check host capability before setting the mode.
> +		 */
> +		tmp = pdom->guest_paging_mode;
> +		if (tmp > amd_iommu_gpt_level) {
> +			pr_err("Cannot support Guest paging mode=%#x
> (dom_id=%#x).\n",
> +			       pdom->guest_paging_mode, pdom->id);
> +			tmp = amd_iommu_gpt_level;
> +		}

why not returning error to the caller