linux-kernel - Re: [PATCH v4 1/8] clk: qcom: ipq5332: add const qualifier to the clk_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 22 Jan 2024 10:02:58 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Kathiravan Thirumoorthy <quic_kathirav@...cinc.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Richard Cochran <richardcochran@...il.com>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 1/8] clk: qcom: ipq5332: add const qualifier to the
 clk_init_data structure

On 22/01/2024 06:56, Kathiravan Thirumoorthy wrote:
> There are few places where clk_init_data structure doesn't carry the const
> qualifier. Let's add the same.

And why should they carry const?

> 
> Acked-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> Signed-off-by: Kathiravan Thirumoorthy <quic_kathirav@...cinc.com>
> ---
>  drivers/clk/qcom/gcc-ipq5332.c | 38 +++++++++++++++++++-------------------
>  1 file changed, 19 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/clk/qcom/gcc-ipq5332.c b/drivers/clk/qcom/gcc-ipq5332.c
> index f98591148a97..66d5399798fe 100644
> --- a/drivers/clk/qcom/gcc-ipq5332.c
> +++ b/drivers/clk/qcom/gcc-ipq5332.c
> @@ -65,7 +65,7 @@ static struct clk_alpha_pll gpll0_main = {
>  static struct clk_fixed_factor gpll0_div2 = {
>  	.mult = 1,
>  	.div = 2,
> -	.hw.init = &(struct clk_init_data) {
> +	.hw.init = &(const struct clk_init_data) {

This is a cast, why do you need const? What does it even change?

Best regards,
Krzysztof