linux-kernel - Re: [PATCH v12 2/2] iio: adc: ad7173: add AD7173 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 22 Jan 2024 12:02:35 +0200
From: Ceclan Dumitru <mitrutzceclan@...il.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: linus.walleij@...aro.org, brgl@...ev.pl, andy@...nel.org,
 linux-gpio@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Michael Walle <michael@...le.cc>,
 Andy Shevchenko <andy.shevchenko@...il.com>, Arnd Bergmann <arnd@...db.de>,
 ChiaEn Wu <chiaen_wu@...htek.com>, Niklas Schnelle <schnelle@...ux.ibm.com>,
 Leonard Göhrs <l.goehrs@...gutronix.de>,
 Mike Looijmans <mike.looijmans@...ic.nl>, Haibo Chen <haibo.chen@....com>,
 Hugo Villeneuve <hvilleneuve@...onoff.com>,
 David Lechner <dlechner@...libre.com>,
 Ceclan Dumitru <dumitru.ceclan@...log.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v12 2/2] iio: adc: ad7173: add AD7173 driver



On 1/21/24 17:50, Jonathan Cameron wrote:
>> +	ret = devm_ad_sd_setup_buffer_and_trigger(dev, indio_dev);
> If the error interrupt is provided either first, or as the only interrupt
> this is going to use the wrong one.
> 
> Probably need to have a variant of that which takes an explicit irq so that
> figuring out which irq is relevant becomes a driver problem rather than the
> library having a go based on spi->irq.

Would it be acceptable to check if spi->irq interrupt number is equal to
fwnode_irq_get_byname(dev_fwnode(dev), "rdy")?

If not, a message could be passed that specifies either that "rdy" is
needed or that it must be placed first.


Another alternative would be adding irq to ad_sigma_delta_info so a
driver could specify the desired interrupt to be used for conversions.