| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 22 Jan 2024 11:06:57 +0100 From: Markus Elfring <Markus.Elfring@....de> To: Dan Carpenter <dan.carpenter@...aro.org>, Kunwu Chan <chentao@...inos.cn>, xen-devel@...ts.xenproject.org, kernel-janitors@...r.kernel.org Cc: LKML <linux-kernel@...r.kernel.org>, kernel test robot <lkp@...el.com>, Boris Ostrovsky <boris.ostrovsky@...cle.com>, Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>, Jürgen Groß <jgross@...e.com>, Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org, Jonathan Corbet <corbet@....net> Subject: Re: [v2] x86/xen: Add some null pointer checking to smp.c >>> How do you think about to use another label like “e_nomem”? >> I'll add a new label to simply the code. > > I'm not a Xen maintainer so I can't really comment on their style choices. Linux contributors can discuss various implementation details. > However, as one of the kernel-janitors list people, I would > say that not everyone agrees with Markus's style preferences. Can a corresponding document be improved accordingly? Centralized exiting of functions https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.8-rc1#n526 Do you find a related information source helpful? https://wiki.sei.cmu.edu/confluence/display/c/MEM12-C.+Consider+using+a+goto+chain+when+leaving+a+function+on+error+when+using+and+releasing+resources Regards, Markus
Powered by blists - more mailing lists