linux-kernel - Re: [PATCH] clk: sunxi: a20-gmac: fix kernel-doc warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 22 Jan 2024 10:44:52 +0000
From: Andre Przywara <andre.przywara@....com>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org, Emilio López
 <emilio@...pez.com.ar>, Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>, linux-clk@...r.kernel.org, Chen-Yu Tsai
 <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>, Samuel Holland
 <samuel@...lland.org>, linux-arm-kernel@...ts.infradead.org,
 linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH] clk: sunxi: a20-gmac: fix kernel-doc warnings

On Sat, 20 Jan 2024 21:18:35 -0800
Randy Dunlap <rdunlap@...radead.org> wrote:

> Move the function kernel-doc comment to be immediately before the
> function implementation, then add a function parameter description
> to prevent kernel-doc warnings:
> 
> clk-a20-gmac.c:43: warning: expecting prototype for sun7i_a20_gmac_clk_setup(). Prototype was for SUN7I_A20_GMAC_GPIT() instead
> clk-a20-gmac.c:53: warning: Function parameter or struct member 'node' not described in 'sun7i_a20_gmac_clk_setup'

Confirmed to be just the move, plus the added parameter description.

Reviewed-by: Andre Przywara <andre.przywara@....com>

Cheers,
Andre
 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Emilio López <emilio@...pez.com.ar>
> Cc: Michael Turquette <mturquette@...libre.com>
> Cc: Stephen Boyd <sboyd@...nel.org>
> Cc: linux-clk@...r.kernel.org
> Cc: Chen-Yu Tsai <wens@...e.org>
> Cc: Jernej Skrabec <jernej.skrabec@...il.com>
> Cc: Samuel Holland <samuel@...lland.org>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-sunxi@...ts.linux.dev
> ---
>  drivers/clk/sunxi/clk-a20-gmac.c |   21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)
> 
> diff -- a/drivers/clk/sunxi/clk-a20-gmac.c b/drivers/clk/sunxi/clk-a20-gmac.c
> --- a/drivers/clk/sunxi/clk-a20-gmac.c
> +++ b/drivers/clk/sunxi/clk-a20-gmac.c
> @@ -15,8 +15,19 @@
>  
>  static DEFINE_SPINLOCK(gmac_lock);
>  
> +
> +#define SUN7I_A20_GMAC_GPIT	2
> +#define SUN7I_A20_GMAC_MASK	0x3
> +#define SUN7I_A20_GMAC_PARENTS	2
> +
> +static u32 sun7i_a20_gmac_mux_table[SUN7I_A20_GMAC_PARENTS] = {
> +	0x00, /* Select mii_phy_tx_clk */
> +	0x02, /* Select gmac_int_tx_clk */
> +};
> +
>  /**
>   * sun7i_a20_gmac_clk_setup - Setup function for A20/A31 GMAC clock module
> + * @node: &struct device_node for the clock
>   *
>   * This clock looks something like this
>   *                               ________________________
> @@ -39,16 +50,6 @@ static DEFINE_SPINLOCK(gmac_lock);
>   * enable/disable this clock to configure the required state. The clock
>   * driver then responds by auto-reparenting the clock.
>   */
> -
> -#define SUN7I_A20_GMAC_GPIT	2
> -#define SUN7I_A20_GMAC_MASK	0x3
> -#define SUN7I_A20_GMAC_PARENTS	2
> -
> -static u32 sun7i_a20_gmac_mux_table[SUN7I_A20_GMAC_PARENTS] = {
> -	0x00, /* Select mii_phy_tx_clk */
> -	0x02, /* Select gmac_int_tx_clk */
> -};
> -
>  static void __init sun7i_a20_gmac_clk_setup(struct device_node *node)
>  {
>  	struct clk *clk;
>