linux-kernel - RE: [PATCH v7 1/2] dt-bindings: iio: frequency: add admfm2000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <PH0PR03MB7141A46C8DD0041775CD0E96F9752@PH0PR03MB7141.namprd03.prod.outlook.com>
Date: Mon, 22 Jan 2024 11:06:08 +0000
From: "Paller, Kim Seer" <KimSeer.Paller@...log.com>
To: Conor Dooley <conor@...nel.org>
CC: "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jonathan
 Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        "Hennerich,
 Michael" <Michael.Hennerich@...log.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley
	<conor+dt@...nel.org>, Crt Mori <cmo@...exis.com>,
        Linus Walleij
	<linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Nuno Sá <noname.nuno@...il.com>
Subject: RE: [PATCH v7 1/2] dt-bindings: iio: frequency: add admfm2000

> > +      adi,mixer-mode:
> > +        description:
> > +          Enable mixer mode.
> > +        type: boolean
> > +
> > +      switch-gpios:
> > +        description: |
> > +          GPIOs to select the RF path for the channel.
> > +          SW-CH1   CTRL-A   CTRL-B
> > +          SW-CH2   CTRL-A   CTRL-B    CH1 Status        CH2 Status
> > +                   1        0         Direct IF mode    Mixer mode
> > +                   0        1         Mixer mode        Direct IF mode
> 
> I cannot make sense of this table you have here, the double header row you
> have going on is hard to follow. There's also no mention here of what happens
> when both GPIOs are 0 or both GPIO are 1. Are these configurations permitted?

I also feel that it's quite hard to understand without the gridlines. In the preliminary
datasheet, it's a switch control table, and I'm trying to replicate the way it is presented.

On the table, each channel has control pins (CTRL-A and CTRL-B). For a mixer mode
configuration on channel 1, CTRL-A GPIO should be 0, and CTRL-B GPIO should be 1.
It's not permitted when both GPIOs are 0 or both GPIOs are 1. The state for the GPIO
should strictly follow the truth table.

I'm considering making it much easier to understand by creating two separate tables for
each channel, just like the example below. Or is it preferred if it could be discussed in 
a sort of paragraph form?

SW-CH1   CTRL-A   CTRL-B    CH1 Status            CH2 Status
	   1              0              Direct IF mode     Mixer

SW-CH2   CTRL-A   CTRL-B    CH1 Status            CH2 Status
          	    0            1               Direct IF mode     Mixer

Best regards,
Kim