linux-kernel - Re: [PATCH v2 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CYL76M5KT424.G3BC6JX74XVN@fairphone.com>
Date: Mon, 22 Jan 2024 12:27:38 +0100
From: "Luca Weiss" <luca.weiss@...rphone.com>
To: <neil.armstrong@...aro.org>, "Linus Walleij" <linus.walleij@...aro.org>
Cc: "Jessica Zhang" <quic_jesszhan@...cinc.com>, "Sam Ravnborg"
 <sam@...nborg.org>, "David Airlie" <airlied@...il.com>, "Daniel Vetter"
 <daniel@...ll.ch>, "Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>,
 "Maxime Ripard" <mripard@...nel.org>, "Thomas Zimmermann"
 <tzimmermann@...e.de>, "Rob Herring" <robh+dt@...nel.org>, "Krzysztof
 Kozlowski" <krzysztof.kozlowski+dt@...aro.org>, "Conor Dooley"
 <conor+dt@...nel.org>, "Bjorn Andersson" <andersson@...nel.org>, "Konrad
 Dybcio" <konrad.dybcio@...aro.org>, "Andy Gross" <agross@...nel.org>,
 <devicetree@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
 <~postmarketos/upstreaming@...ts.sr.ht>, <phone-devel@...r.kernel.org>
Subject: Re: [PATCH v2 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

On Fri Jan 12, 2024 at 11:26 AM CET,  wrote:
> On 12/01/2024 11:23, Linus Walleij wrote:
> > On Fri, Jan 12, 2024 at 10:52 AM Luca Weiss <luca.weiss@...rphone.com> wrote:
> > 
> >> Since there's zero indication Truly is involved in this panel in my
> >> documentation - much less the number 5P65 - I'm not going to add that.
>
> Ack
>
> > 
> > OK then, I fold, thanks for looking into it.
> > Keep the Himax hx83112a file name and symbols.
> > 
> >> So in short this panel is the model 9A-3R063-1102B from DJN, which uses
> >> a Himax HX83112A driver IC.
> > 
> > So compatible = "djn,9a-3r063-1102b" since the setup sequences for
> > hx83112a are clearly for this one display?
>
> Yep let's settle on that!

It's clear to me to use "djn,9a-3r063-1102b" in the driver now but what
about dts?

Currently here in v2 we have this:
compatible = "fairphone,fp4-hx83112a-djn", "himax,hx83112a";

Should this just become this?
compatible = "djn,9a-3r063-1102b";

Or e.g. this?
compatible = "djn,9a-3r063-1102b", "himax,hx83112a";

Or something else completely? Do we have some documentation / best
practises around this maybe?

Regards
Luca

>
> Thanks,
> Neil
>
> > 
> > Yours,
> > Linus Walleij