linux-kernel - Re: [PATCH v5 3/3] iio: light: Add support for APDS9306 Light Sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3be58246-1a39-45f9-981f-7ada71868a4b@tweaklogic.com>
Date: Mon, 22 Jan 2024 22:12:00 +1030
From: Subhajit Ghosh <subhajit.ghosh@...aklogic.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: anshulusr@...il.com, conor+dt@...nel.org, devicetree@...r.kernel.org,
 javier.carrasco.cruz@...il.com, jic23@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, lars@...afoo.de,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, marex@...x.de,
 matt@...ostay.sg, mazziesaccount@...il.com, robh+dt@...nel.org,
 stefan.windfeldt-prytz@...s.com
Subject: Re: [PATCH v5 3/3] iio: light: Add support for APDS9306 Light Sensor

On 21/1/24 23:22, Andy Shevchenko wrote:
> On Sun, Jan 21, 2024 at 10:22:50AM +0100, Christophe JAILLET wrote:

> Seems like entire conditional here is not needed as it's implied in the max().
> And max() should take both signed or unsigned types, different types might have
> a side effect.
Ok, understood.
> 
>>> +	/*
>>> +	 * Whichever is greater - integration time period or
>>> +	 * sampling period.
>>> +	 */
>>> +	delay = max(intg_time,
>>> +		    apds9306_repeat_rate_period[repeat_rate_idx]);
> 
Thanks for the review.

Regards,
Subhajit Ghosh