linux-kernel - Re: [PATCH] x86/alternatives: Fix switch block in apply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240122132057.GAZa5ruRCBJzuuVKC9@fat_crate.local>
Date: Mon, 22 Jan 2024 14:20:57 +0100
From: Borislav Petkov <bp@...en8.de>
To: Pranav Athreya <pranavsubbu@...il.com>
Cc: Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
	Pranav Athreya <pranavsubbugmail.com@...-os.smtp.subspace.kernel.org>
Subject: Re: [PATCH] x86/alternatives: Fix switch block in apply_reloc()

On Mon, Jan 22, 2024 at 06:45:27PM +0530, Pranav Athreya wrote:
> -	case 1: apply_reloc_n(8, ptr, diff); break;
> -	case 2: apply_reloc_n(16, ptr, diff); break;
> -	case 4: apply_reloc_n(32, ptr, diff); break;
> -	default: BUG();

It is more compact and faster readable this way. Do not always take what
checkpatch tells you to the letter.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette