linux-kernel - Re: [PATCH v4 3/5] perf: script: add field 'disasm' to display mnemonic instructions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240122140527.36j2jcd6abdbtlgm@mail.google.com>
Date: Mon, 22 Jan 2024 22:05:27 +0800
From: Changbin Du <changbin.du@...il.com>
To: Andi Kleen <ak@...ux.intel.com>
Cc: Changbin Du <changbin.du@...wei.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
	Ian Rogers <irogers@...gle.com>, linux-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org,
	Thomas Richter <tmricht@...ux.ibm.com>, changbin.du@...il.com,
	Peter Zijlstra <peterz@...radead.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH v4 3/5] perf: script: add field 'disasm' to display
 mnemonic instructions

On Mon, Jan 22, 2024 at 05:41:42AM -0800, Andi Kleen wrote:
> > > >>
> > > > Updated as:
> > > > 
> > > > 	When doing instruction trace decoding, insn, disasm and insnlen give the
> > > > 	instruction bytes, disassembled instructions and the instruction length
> > > > 	of the current instruction respectively.
> > > 
> > > I wondered about mentioning that disasm needs perf to be compiled with
> > > disassembler support, but with a permissive license it seems likely
> > > that libcapstone support would generally be built into perf, so that
> > > should be fine.
> > > 
> > Yes, libcapstone has a permissive license. It's available on most Linux distros.
> 
> What I've seen in the past is that people who build perf from source
> often miss installing all the build the dependencies because perf continues
> without an error. Make sure that if that happens and someone uses the option
> there is a clear message that points to the build process.
>

Currently, perf build will show libcapstone available status at the beginning
of build and prompt user how to install it, as other dependencies do.

> -Andi

-- 
Cheers,
Changbin Du