linux-kernel - Re: [PATCH v2] kbuild: resolve symlinks for O= properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 22 Jan 2024 15:12:03 +0100
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, Nicolas Schier <n.schier@....de>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Nicolas Schier <nicolas@...sle.eu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] kbuild: resolve symlinks for O= properly

On 2023-12-16 01:06:37 [+0900], Masahiro Yamada wrote:
…
> Using the physical directory structure for the O= option seems more
> reasonable.
> 
> The comment says "expand a shell special character '~'", but it has
> already been expanded to the home directory in the command line.

It might have been expanded, it might have not been expanded. Having a
shell script:
| #!/bin/sh
| 
| exec make O=~/scratch/mk-check defconfig

with bin/sh = dash results in:

| make[1]: Entering directory '/home/bigeasy/linux/~/scratch/mk-check'

while bin/sh = bash expands the ~ properly before for O=. Would it be
too much to ask, to expand the ~?

Sebastian