linux-kernel - Re: [PATCH V1] vdpa_sim: reset must not run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACGkMEsSjtkYk3++aqmPxrivrDzyGxNumiancRxAfY=7D3SsiA@mail.gmail.com>
Date: Mon, 22 Jan 2024 12:12:54 +0800
From: Jason Wang <jasowang@...hat.com>
To: Steve Sistare <steven.sistare@...cle.com>
Cc: virtualization@...ts.linux-foundation.org, linux-kernel@...r.kernel.org, 
	"Michael S. Tsirkin" <mst@...hat.com>, Eugenio Perez Martin <eperezma@...hat.com>, Si-Wei Liu <si-wei.liu@...cle.com>, 
	Stefano Garzarella <sgarzare@...hat.com>
Subject: Re: [PATCH V1] vdpa_sim: reset must not run

On Thu, Jan 18, 2024 at 3:23 AM Steve Sistare <steven.sistare@...cle.com> wrote:
>
> vdpasim_do_reset sets running to true, which is wrong, as it allows
> vdpasim_kick_vq to post work requests before the device has been
> configured.  To fix, do not set running until VIRTIO_CONFIG_S_FEATURES_OK
> is set.
>
> Fixes: 0c89e2a3a9d0 ("vdpa_sim: Implement suspend vdpa op")
> Signed-off-by: Steve Sistare <steven.sistare@...cle.com>
> Reviewed-by: Eugenio Pérez <eperezma@...hat.com>

Acked-by: Jason Wang <jasowang@...hat.com>

Thanks