linux-kernel - Re: [PATCH 1/4] ARM: dts: qcom: msm8974-samsung-klte: Add label on /i2c-gpio-led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3647c5f823260865eb870ff1ce45c787bcaec256.camel@rong.moe>
Date: Mon, 22 Jan 2024 22:54:08 +0800
From: Rong Zhang <i@...g.moe>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Bjorn Andersson
 <andersson@...nel.org>, Konrad Dybcio <konrad.dybcio@...aro.org>, Rob
 Herring <robh+dt@...nel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@...aro.org>,  Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Icenowy Zheng <uwu@...nowy.me>
Subject: Re: [PATCH 1/4] ARM: dts: qcom: msm8974-samsung-klte: Add label on
 /i2c-gpio-led

On Mon, 2024-01-22 at 10:48 +0100, Krzysztof Kozlowski wrote:
> On 21/01/2024 16:39, Rong Zhang wrote:
> > Some variants of klte, e.g., the China edition (kltechn), have minor
> > differences to differentiate them from klte. This includes the GPIO pins
> > connected to /i2c-gpio-led.
> > 
> > A label is added on /i2c-gpio-led to allow DT of other variants to
> > reference it conveniently. Considering both LEDs and a GPIO expander are
> > connected to the node, it is named "i2c_led_gpio".
> > 
> > Signed-off-by: Rong Zhang <i@...g.moe>
> > ---
> >  arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts
> > index b93539e2b87e..013946ccda0f 100644
> > --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts
> > +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts
> > @@ -77,7 +77,7 @@ touchkey@20 {
> >  		};
> >  	};
> >  
> > -	i2c-gpio-led {
> > +	i2c_led_gpio: i2c-gpio-led {
> 
> This does not make much sense on its own. 6 commit msg lines just to add
> a label. Squash it.

Will squash it into "[PATCH 4/4] ARM: dts: qcom: msm8974: Add device
tree for Samsung Galaxy S5 China".

Thanks,
Rong


> Best regards,
> Krzysztof
>