linux-kernel - Re: [PATCH 1/2] ASoC: dt-bindings: Added schema for "nuvoton,nau8325"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <185f3912-5a92-4ef2-aac4-0df8363d8727@sirena.org.uk>
Date: Tue, 23 Jan 2024 13:06:45 +0000
From: Mark Brown <broonie@...nel.org>
To: Conor Dooley <conor@...nel.org>
Cc: Seven Lee <wtli@...oton.com>, lgirdwood@...il.com,
	alsa-devel@...a-project.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, robh+dt@...nel.org,
	conor+dt@...nel.org, YHCHuang@...oton.com, KCHSU0@...oton.com,
	CTLIN0@...oton.com, SJLIN0@...oton.com, scott6986@...il.com,
	supercraig0719@...il.com, dardar923@...il.com
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: Added schema for "nuvoton,nau8325"

On Tue, Jan 23, 2024 at 08:34:03AM +0000, Conor Dooley wrote:
> On Mon, Jan 22, 2024 at 07:40:51PM +0000, Mark Brown wrote:
> > On Mon, Jan 22, 2024 at 06:00:14PM +0000, Conor Dooley wrote:
> > > On Mon, Jan 22, 2024 at 05:56:49PM +0800, Seven Lee wrote:

> > > > +    enum:
> > > > +      - 0 # VDDA
> > > > +      - 1 # VDDA*1.5/1.8V
> > > > +      - 2 # VDDA*1.6/1.8V
> > > > +      - 3 # VDDA*1.7/1.8V

> > > I would also rather than this enum was used to have sensible values for
> > > the enum itself (which I suppose means strings here), rather than the
> > > register values. Seeing "nuvoton,dac-vref = <2>" in a devicetree is not
> > > very meaningful IMO.

> > Do you have a concrete suggestion for how to more clearly write these
> > directly?

> I would use what's been given as the explanation comments for each of
> the current enum values in the patch.

Given that none of *, / nor . are usable in defines that's going to need
a bit of massaging...

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)