linux-kernel - Re: [PATCH] ARM: fault: Implement copy_from_kernel_nofault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXGDqPEBO1jm3FqN2dLPPTDL+xdW9mNCUV16bfJ+AtmS-Q@mail.gmail.com>
Date: Tue, 23 Jan 2024 14:44:37 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Kees Cook <keescook@...omium.org>
Cc: Russell King <linux@...linux.org.uk>, Mark Brown <broonie@...nel.org>, 
	Wang Kefeng <wangkefeng.wang@...wei.com>, Andrew Morton <akpm@...ux-foundation.org>, 
	Ben Hutchings <ben@...adent.org.uk>, linux-arm-kernel@...ts.infradead.org, 
	"Russell King (Oracle)" <rmk+kernel@...linux.org.uk>, Hugh Dickins <hughd@...gle.com>, 
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] ARM: fault: Implement copy_from_kernel_nofault_allowed()

On Tue, 23 Jan 2024 at 02:12, Kees Cook <keescook@...omium.org> wrote:
>
> Under PAN emulation when dumping backtraces from things like the
> LKDTM EXEC_USERSPACE test[1], a double fault (which would hang a CPU)
> would happen because of dump_instr() attempting to read a userspace
> address. Make sure copy_from_kernel_nofault() does not attempt this
> any more.
>
> Reported-by: Mark Brown <broonie@...nel.org>
> Link: https://lore.kernel.org/all/202401181125.D48DCB4C@keescook/ [1]
> Suggested-by: "Russell King (Oracle)" <linux@...linux.org.uk>
> Cc: Russell King <linux@...linux.org.uk>
> Cc: Ard Biesheuvel <ardb@...nel.org>
> Cc: Wang Kefeng <wangkefeng.wang@...wei.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Ben Hutchings <ben@...adent.org.uk>
> Cc: linux-arm-kernel@...ts.infradead.org
> Signed-off-by: Kees Cook <keescook@...omium.org>

Reviewed-by: Ard Biesheuvel <ardb@...nel.org>

> ---
>  arch/arm/mm/fault.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/mm/fault.c b/arch/arm/mm/fault.c
> index e804432e905e..bc5b959b6f90 100644
> --- a/arch/arm/mm/fault.c
> +++ b/arch/arm/mm/fault.c
> @@ -25,6 +25,13 @@
>
>  #include "fault.h"
>
> +bool copy_from_kernel_nofault_allowed(const void *unsafe_src, size_t size)
> +{
> +       unsigned long addr = (unsigned long)unsafe_src;
> +
> +       return addr >= TASK_SIZE && ULONG_MAX - addr >= size;
> +}
> +
>  #ifdef CONFIG_MMU
>
>  /*
> --
> 2.34.1
>