linux-kernel - Re: [PATCH] ARM: fault: Add "cut here" line for prefetch aborts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXG3kqRy0KEvC_+f+RAgeZvcKRwHGKTbLNj34pr8rhzTdw@mail.gmail.com>
Date: Tue, 23 Jan 2024 14:46:07 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Kees Cook <keescook@...omium.org>
Cc: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>, Wang Kefeng <wangkefeng.wang@...wei.com>, 
	Ben Hutchings <ben@...adent.org.uk>, linux-arm-kernel@...ts.infradead.org, 
	Russell King <linux@...linux.org.uk>, Hugh Dickins <hughd@...gle.com>, 
	Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, 
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] ARM: fault: Add "cut here" line for prefetch aborts

On Tue, 23 Jan 2024 at 02:12, Kees Cook <keescook@...omium.org> wrote:
>
> The common pattern in arm is to emit a "8<--- cut here ---" line for
> faults, but it was missing for do_PrefetchAbort(). Add it.
>
> Cc: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
> Cc: Ard Biesheuvel <ardb@...nel.org>
> Cc: Wang Kefeng <wangkefeng.wang@...wei.com>
> Cc: Ben Hutchings <ben@...adent.org.uk>
> Cc: linux-arm-kernel@...ts.infradead.org
> Signed-off-by: Kees Cook <keescook@...omium.org>

Acked-by: Ard Biesheuvel <ardb@...nel.org>

> ---
>  arch/arm/mm/fault.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mm/fault.c b/arch/arm/mm/fault.c
> index e96fb40b9cc3..e804432e905e 100644
> --- a/arch/arm/mm/fault.c
> +++ b/arch/arm/mm/fault.c
> @@ -586,6 +586,7 @@ do_PrefetchAbort(unsigned long addr, unsigned int ifsr, struct pt_regs *regs)
>         if (!inf->fn(addr, ifsr | FSR_LNX_PF, regs))
>                 return;
>
> +       pr_alert("8<--- cut here ---\n");
>         pr_alert("Unhandled prefetch abort: %s (0x%03x) at 0x%08lx\n",
>                 inf->name, ifsr, addr);
>
> --
> 2.34.1
>