[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
<DU0PR04MB9417C970935FCB14F92F1E3588742@DU0PR04MB9417.eurprd04.prod.outlook.com>
Date: Tue, 23 Jan 2024 15:16:02 +0000
From: Peng Fan <peng.fan@....com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, "Peng Fan (OSS)"
<peng.fan@....nxp.com>, Jassi Brar <jassisinghbrar@...il.com>, Rob Herring
<robh+dt@...nel.org>, Krzysztof Kozlowski
<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
Aisheng Dong <aisheng.dong@....com>, Shawn Guo <shawnguo@...nel.org>, Sascha
Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
<kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, dl-linux-imx
<linux-imx@....com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v3 1/4] dt-bindings: mailbox: fsl,mu: add i.MX95
Generic/ELE/V2X MU compatible
> Subject: Re: [PATCH v3 1/4] dt-bindings: mailbox: fsl,mu: add i.MX95
> Generic/ELE/V2X MU compatible
>
> On 23/01/2024 15:38, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@....com>
> >
> > Add i.MX95 Generic, Secure Enclave and V2X Message Unit compatible
> string.
> > And some MUs has internal RAMs for SCMI shared buffer usage.
> >
> > Signed-off-by: Peng Fan <peng.fan@....com>
> > ---
> > .../devicetree/bindings/mailbox/fsl,mu.yaml | 50
> +++++++++++++++++++++-
> > 1 file changed, 48 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > index 12e7a7d536a3..569fabc5285c 100644
> > --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > @@ -29,10 +29,14 @@ properties:
> > - const: fsl,imx8ulp-mu
> > - const: fsl,imx8-mu-scu
> > - const: fsl,imx8-mu-seco
> > - - const: fsl,imx93-mu-s4
> > - const: fsl,imx8ulp-mu-s4
> > + - const: fsl,imx93-mu-s4
> > + - const: fsl,imx95-mu-ele
> > + - const: fsl,imx95-mu-v2x
> > - items:
> > - - const: fsl,imx93-mu
> > + - enum:
> > + - fsl,imx93-mu
> > + - fsl,imx95-mu
> > - const: fsl,imx8ulp-mu
> > - items:
> > - enum:
> > @@ -95,6 +99,17 @@ properties:
> > power-domains:
> > maxItems: 1
> >
> > + ranges: true
> > +
> > + "#address-cells": true
> > +
> > + "#size-cells": true
> > +
> > +patternProperties:
> > + "^sram@[a-z0-9]+":
>
> This is a friendly reminder during the review process.
>
Oh, sorry, I overlooked this. Will send out v4 later, waiting
to see whether Sascha has comments on the driver part.
Thanks,
Peng.
> It seems my or otSher reviewer's previous comments were not fully addressed.
> Maybe the feedback got lost between the quotes, maybe you just forgot to
> apply it. Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
> Thank you.
>
> Best regards,
> Krzysztof
Powered by blists - more mailing lists