linux-kernel - Re: [PATCH 1/2] blk-mq: introduce blk_mq_tagset_wait_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202401240242.k3K7SkiZ-lkp@intel.com>
Date: Wed, 24 Jan 2024 02:45:29 +0800
From: kernel test robot <lkp@...el.com>
To: Yi Sun <yi.sun@...soc.com>, axboe@...nel.dk, mst@...hat.com,
	jasowang@...hat.com
Cc: oe-kbuild-all@...ts.linux.dev, xuanzhuo@...ux.alibaba.com,
	pbonzini@...hat.com, stefanha@...hat.com,
	virtualization@...ts.linux.dev, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, yi.sun@...soc.com,
	zhiguo.niu@...soc.com, hongyu.jin@...soc.com, sunyibuaa@...il.com
Subject: Re: [PATCH 1/2] blk-mq: introduce
 blk_mq_tagset_wait_request_completed()

Hi Yi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on axboe-block/for-next]
[also build test WARNING on linus/master v6.8-rc1 next-20240123]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yi-Sun/blk-mq-introduce-blk_mq_tagset_wait_request_completed/20240122-192222
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link:    https://lore.kernel.org/r/20240122110722.690223-2-yi.sun%40unisoc.com
patch subject: [PATCH 1/2] blk-mq: introduce blk_mq_tagset_wait_request_completed()
config: i386-buildonly-randconfig-002-20240123 (https://download.01.org/0day-ci/archive/20240124/202401240242.k3K7SkiZ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240124/202401240242.k3K7SkiZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401240242.k3K7SkiZ-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> block/blk-mq-tag.c:498: warning: Function parameter or struct member 'tagset' not described in 'blk_mq_tagset_wait_request_completed'


vim +498 block/blk-mq-tag.c

   490	
   491	/**
   492	 * blk_mq_tagset_wait_request_completed - Wait for all inflight requests
   493	 * to become completed.
   494	 *
   495	 * Note: This function has to be run after all IO queues are shutdown.
   496	 */
   497	void blk_mq_tagset_wait_request_completed(struct blk_mq_tag_set *tagset)
 > 498	{
   499		while (true) {
   500			unsigned int count = 0;
   501	
   502			blk_mq_tagset_busy_iter(tagset,
   503					blk_mq_tagset_count_inflight_rqs, &count);
   504			if (!count)
   505				break;
   506			msleep(20);
   507		}
   508	}
   509	EXPORT_SYMBOL(blk_mq_tagset_wait_request_completed);
   510	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki