linux-kernel - Re: [PATCH] Revert "drivers/firmware: Move sysfb_init() from device_initcall to subsys_initcall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871qa7n9l2.fsf@intel.com>
Date: Tue, 23 Jan 2024 21:17:13 +0200
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Thomas Zimmermann <tzimmermann@...e.de>, javierm@...hat.com,
 chenhuacai@...nel.org
Cc: linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, Thorsten
 Leemhuis <regressions@...mhuis.info>, Thomas Zimmermann
 <tzimmermann@...e.de>, Jaak Ristioja <jaak@...tioja.ee>, Huacai Chen
 <chenhuacai@...ngson.cn>
Subject: Re: [PATCH] Revert "drivers/firmware: Move sysfb_init() from
 device_initcall to subsys_initcall_sync"

On Tue, 23 Jan 2024, Jani Nikula <jani.nikula@...ux.intel.com> wrote:
> On Tue, 23 Jan 2024, Thomas Zimmermann <tzimmermann@...e.de> wrote:
>> This reverts commit 60aebc9559492cea6a9625f514a8041717e3a2e4.
>>
>> Commit 60aebc9559492cea ("drivers/firmware: Move sysfb_init() from
>> device_initcall to subsys_initcall_sync") messes up initialization order
>> of the graphics drivers and leads to blank displays on some systems. So
>> revert the commit.
>>
>> To make the display drivers fully independent from initialization
>> order requires to track framebuffer memory by device and independently
>> from the loaded drivers. The kernel currently lacks the infrastructure
>> to do so.
>>
>> Reported-by: Jaak Ristioja <jaak@...tioja.ee>
>> Closes: https://lore.kernel.org/dri-devel/ZUnNi3q3yB3zZfTl@P70.localdomain/T/#t
>> Reported-by: Huacai Chen <chenhuacai@...ngson.cn>
>> Closes: https://lore.kernel.org/dri-devel/20231108024613.2898921-1-chenhuacai@loongson.cn/
>> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10133
>
> FWIW,
>
> Acked-by: Jani Nikula <jani.nikula@...el.com>
>
> but would be great to get a Tested-by from Jaak or from the gitlab issue
> reporter.

The revert works for the gitlab issue reporter.

BR,
Jani.



-- 
Jani Nikula, Intel