linux-kernel - Re: [PATCH v4 0/6] reset: gpio: ASoC: shared GPIO resets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 23 Jan 2024 19:28:08 +0000
From: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Bjorn Andersson
	<andersson@...nel.org>, Konrad Dybcio <konrad.dybcio@...aro.org>, "Srinivas
 Kandagatla" <srinivas.kandagatla@...aro.org>, Banajit Goswami
	<bgoswami@...cinc.com>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown
	<broonie@...nel.org>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>, "Rafael J. Wysocki"
	<rafael@...nel.org>, Viresh Kumar <viresh.kumar@...aro.org>, Frank Rowand
	<frowand.list@...il.com>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai
	<tiwai@...e.com>, "linux-arm-msm@...r.kernel.org"
	<linux-arm-msm@...r.kernel.org>, "alsa-devel@...a-project.org"
	<alsa-devel@...a-project.org>, "linux-sound@...r.kernel.org"
	<linux-sound@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-pm@...r.kernel.org"
	<linux-pm@...r.kernel.org>
CC: Bartosz Golaszewski <brgl@...ev.pl>, Sean Anderson
	<sean.anderson@...o.com>
Subject: Re: [PATCH v4 0/6] reset: gpio: ASoC: shared GPIO resets


On 24/01/24 03:13, Krzysztof Kozlowski wrote:
> Hi,
>
> Patch #2 (cpufreq: do not open-code of_phandle_args_equal()) and patch #4
> (reset: Instantiate reset GPIO controller for shared reset-gpios) depend on OF
> change (patch #1).
>
> Changes in v4
> =============
> 1. New patches:
>     of: add of_phandle_args_equal() helper
>     cpufreq: do not open-code of_phandle_args_equal()
>
> 2. reset-gpio.c:
>     - Drop unneeded comment (Bartosz), add Rb tag.
>     - Do not assign of_node.
>
> 3. reset/core.c:
>     - Implement most of Bartosz feedback (I responded to one which I did not
>       implement) and comments from Philipp.
>     - Expect either rcdev->of_args or rcdev->of_node.
>     - Drop __reset_gpios_args_match() and use common helper (Philipp).
>     - Move declarations of automatic-cleanup variables in
>       __reset_add_reset_gpio_lookup() to place of use (Bartosz).
>     - Separate gpio_device_get_label() and kstrdup() (Philipp).
>     - Correct doc for __reset_add_reset_gpio_device(), rewrite few comments.
>     - Drop unneeded "r" variable in __reset_find_rcdev() (Philipp).
>     - Drop of_phandle_args initialization in __of_reset_control_get (Philipp).
>     - Check if CONFIG_RESET_GPIO is enabled before trying to look up reset-gpios.
>
> 4. Drop Chris' patch: "i2c: muxes: pca954x: Allow sharing reset GPIO", because
>     discussion is on going.

I actually think it would have been OK as-is with your latest change to 
return NULL when CONFIG_RESET_GPIO is not enabled. But I'm happy to 
submit it independently after this series lands. It'll give me a chance 
to do a bit more testing.