linux-kernel - Re: [GIT PULL] SPI updates for v6.8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18520c6ce5361861d31547d112374f22c31f2d97.camel@gmail.com>
Date: Tue, 23 Jan 2024 20:57:58 +0100
From: Klaus Kudielka <klaus.kudielka@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] SPI updates for v6.8

On Mon, 2024-01-22 at 18:38 +0000, Mark Brown wrote:
> On Mon, Jan 22, 2024 at 07:30:09PM +0100, Klaus Kudielka wrote:
> > On Sun, 2024-01-07 at 22:38 +0000, Mark Brown wrote:
> 
> > I just booted 6.8.0-rc1 on Turris Omnia (CONFIG_SPI_ORION=y,
> > device tree: arch/arm/boot/dts/marvell/armada-385-turris-omnia.dts)
> 
> > and got the following error:
> > 
> > [    0.090231] spi_master spi0: No. of CS is more than max. no. of supported CS
> > [    0.097358] spi_master spi0: Failed to create SPI device for /soc/spi@...00/flash@0
> > 
> > End result: the three MTD partitions I used to have on the SPI-NOR are gone.
> 
> Actualy looking at the DT it's not immediately obvious why this is
> triggering - there's only one chip select in use, numbered 0 AFAICT.
> Anyway, if you could test the patch I linked hopefully it does fix the
> issue.

For the records, drivers/spi/spi-orion.c states:

/* Some SoCs using this driver support up to 8 chip selects.
 * It is up to the implementer to only use the chip selects
 * that are available.
 */
#define ORION_NUM_CHIPSELECTS           8

[...]

and then in orion_spi_probe():

        host->num_chipselect = ORION_NUM_CHIPSELECTS;