linux-kernel - Re: [PATCH 2/5] dm: dm-zoned: pass GFP_KERNEL to blkdev_zone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55226421-ce21-f769-94e0-d42c97e55e7d@redhat.com>
Date: Tue, 23 Jan 2024 21:18:45 +0100 (CET)
From: Mikulas Patocka <mpatocka@...hat.com>
To: Johannes Thumshirn <johannes.thumshirn@....com>
cc: Damien Le Moal <dlemoal@...nel.org>, Naohiro Aota <naohiro.aota@....com>, 
    Mike Snitzer <snitzer@...nel.org>, dm-devel@...ts.linux.dev, 
    Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>, 
    David Sterba <dsterba@...e.com>, Jaegeuk Kim <jaegeuk@...nel.org>, 
    Chao Yu <chao@...nel.org>, Jens Axboe <axboe@...nel.dk>, 
    Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>, 
    Chaitanya Kulkarni <kch@...dia.com>, linux-fsdevel@...r.kernel.org, 
    linux-kernel@...r.kernel.org, linux-btrfs@...r.kernel.org, 
    linux-f2fs-devel@...ts.sourceforge.net, linux-block@...r.kernel.org, 
    linux-nvme@...ts.infradead.org, 
    "Matthew Wilcox (Oracle)" <willy@...radead.org>
Subject: Re: [PATCH 2/5] dm: dm-zoned: pass GFP_KERNEL to blkdev_zone_mgmt



On Tue, 23 Jan 2024, Johannes Thumshirn wrote:

> The call to blkdev_zone_mgmt() in dm-zoned is only used to perform a
> ZONE_RESET operation when freeing a zone.
> 
> This is not done in the IO path, so we can use GFP_KERNEL here, as it will
> never recurse back into the driver on reclaim.

Hi

This doesn't seem safe to me. There's a possible call chain dmz_handle_bio 
-> dmz_put_chunk_mapping -> dmz_free_zone -> dmz_reset_zone -> 
blkdev_zone_mgmt -> recursion (via GFP_KERNEL) back into the dm-zoned 
target.

Mikulas

> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@....com>
> ---
>  drivers/md/dm-zoned-metadata.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c
> index fdfe30f7b697..a39734f0cb7d 100644
> --- a/drivers/md/dm-zoned-metadata.c
> +++ b/drivers/md/dm-zoned-metadata.c
> @@ -1658,7 +1658,7 @@ static int dmz_reset_zone(struct dmz_metadata *zmd, struct dm_zone *zone)
>  
>  		ret = blkdev_zone_mgmt(dev->bdev, REQ_OP_ZONE_RESET,
>  				       dmz_start_sect(zmd, zone),
> -				       zmd->zone_nr_sectors, GFP_NOIO);
> +				       zmd->zone_nr_sectors, GFP_KERNEL);
>  		if (ret) {
>  			dmz_dev_err(dev, "Reset zone %u failed %d",
>  				    zone->id, ret);
> 
> -- 
> 2.43.0
> 
>