linux-kernel - Re: [PATCH 0/5] Fix and cleanups to page-writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZbAlqdwNv_uxnKT1@slm.duckdns.org>
Date: Tue, 23 Jan 2024 10:46:33 -1000
From: Tejun Heo <tj@...nel.org>
To: Kemeng Shi <shikemeng@...weicloud.com>
Cc: willy@...radead.org, akpm@...ux-foundation.org,
	hcochran@...nelspring.com, mszeredi@...hat.com, axboe@...nel.dk,
	linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] Fix and cleanups to page-writeback

On Wed, Jan 24, 2024 at 02:33:27AM +0800, Kemeng Shi wrote:
> This series contains some random cleanups and a fix to correct
> calculation of cgroup wb's bg_thresh. More details can be found
> respective patches. Thanks!
> 
> Kemeng Shi (5):
>   mm: enable __wb_calc_thresh to calculate dirty background threshold
>   mm: correct calculation of cgroup wb's bg_thresh in wb_over_bg_thresh
>   mm: call __wb_calc_thresh instead of wb_calc_thresh in
>     wb_over_bg_thresh
>   mm: remove redundant check in wb_min_max_ratio
>   mm: remove stale comment __folio_mark_dirty

I don't have the fifth patch in my inbox and I find the patchset difficult
to review because it's changing subtle behaviors without sufficient
justifications or concrete cases which motivated the changes. For now, I
think it'd be prudent to not apply this patchset.

Thanks.

-- 
tejun