linux-kernel - Re: [PATCH 05/21] spi: s3c64xx: explicitly include <linux/bits.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6cfc5715-a4b8-41b4-ad82-95f9519301d0@sirena.org.uk>
Date: Tue, 23 Jan 2024 22:42:22 +0000
From: Mark Brown <broonie@...nel.org>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: Tudor Ambarus <tudor.ambarus@...aro.org>, arnd@...db.de,
	robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
	conor+dt@...nel.org, alim.akhtar@...sung.com,
	linux-spi@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-arch@...r.kernel.org,
	andre.draszik@...aro.org, peter.griffin@...aro.org,
	semen.protsenko@...aro.org, kernel-team@...roid.com,
	willmcvicker@...gle.com
Subject: Re: [PATCH 05/21] spi: s3c64xx: explicitly include <linux/bits.h>

On Tue, Jan 23, 2024 at 11:28:31PM +0100, Andi Shyti wrote:
> On Tue, Jan 23, 2024 at 03:34:04PM +0000, Tudor Ambarus wrote:

> > +#include <linux/bits.h>

> I don't see why this should be included. Are there cases when
> not having bits.h produces any compilation error?

It is good practice to directly include all headers used, it avoids
implicit dependencies and spurious breakage if someone rearranges
headers and causes the implicit include to vanish.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)