linux-kernel - Re: [PATCH V2 03/13] drivers: soundwire: amd: refactor amd soundwire manager device node creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Za9nrtvDtCT_SLzY@matsya>
Date: Tue, 23 Jan 2024 12:45:59 +0530
From: Vinod Koul <vkoul@...nel.org>
To: "Mukunda,Vijendar" <vijendar.mukunda@....com>
Cc: broonie@...nel.org, alsa-devel@...a-project.org,
	yung-chuan.liao@...ux.intel.com,
	pierre-louis.bossart@...ux.intel.com, Basavaraj.Hiregoudar@....com,
	Sunil-kumar.Dommati@....com, vinod.koul@...el.com,
	venkataprasad.potturu@....com,
	Sanyog Kale <sanyog.r.kale@...el.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 03/13] drivers: soundwire: amd: refactor amd soundwire
 manager device node creation

On 22-01-24, 17:18, Mukunda,Vijendar wrote:
> On 22/01/24 13:27, Vinod Koul wrote:
> > On 10-01-24, 15:14, Vijendar Mukunda wrote:

> >
> >> + * @count: link count
> >> + * @num_slaves: total number of devices exposed across all enabled links
> > should this be not per link?
> No, this will be total count of peripheral devices across all the links.
> This variable will be used in  snd_soc_acpi_sdw_link_slaves_found()
> API.

yeah noticed later

> >
> >> + * @link_mask: bit-wise mask listing SoundWire links reported by the
> >> + * Controller
> >> + * @ids: array of slave_id, representing Slaves exposed across all enabled
> >> + * links
> > this does not tell us which device to expect in which link..?
> sdw_extended_slave_id structure contains information about link id as well.

ok

-- 
~Vinod