linux-kernel - Re: [PATCH v1] PM: sleep: Use bool for all 1-bit fields in struct dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Za+DZVM6Dd2YRsWL@linux.intel.com>
Date: Tue, 23 Jan 2024 10:14:13 +0100
From: Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>
To: "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc: Linux PM <linux-pm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v1] PM: sleep: Use bool for all 1-bit fields in struct
 dev_pm_info

On Mon, Jan 22, 2024 at 05:11:26PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> For some 1-bit fields in struct dev_pm_info the data type is bool, while
> for some other 1-bit fields in there it is unsigned int, and these
> differences are somewhat arbitrary.
> 
> For consistency, change the data type of the latter to bool, so that all
> of the 1-bit fields in struct dev_pm_info fields are bool.
> 
> This also reduces the size of struct device on my x86 systems by 8 B,
> from 1120 B to 1112 B.
> 
> No intentional functional impact.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>