linux-kernel - Re: [PATCH] dt-bindings: memory-controllers: narrow regex for unit address to hex numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 23 Jan 2024 10:45:30 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Jon Hunter <jonathanh@...dia.com>, Rob Herring <robh+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Thierry Reding
 <thierry.reding@...il.com>, Dmitry Osipenko <digetx@...il.com>,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-tegra@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: memory-controllers: narrow regex for unit
 address to hex numbers

On 23/01/2024 10:20, Jon Hunter wrote:
> 
> On 23/01/2024 08:35, Krzysztof Kozlowski wrote:
>> Regular expression used to match the unit address part should not allow
>> non-hex numbers.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
>>   .../bindings/memory-controllers/nvidia,tegra20-emc.yaml         | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
>> index f54e553e6c0e..71896cb10692 100644
>> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
>> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
>> @@ -145,7 +145,7 @@ patternProperties:
>>     "^emc-table@[0-9]+$":
>>       $ref: "#/$defs/emc-table"
>>   
>> -  "^emc-tables@[a-z0-9-]+$":
>> +  "^emc-tables@[a-f0-9-]+$":
>>       type: object
>>       properties:
>>         reg:
> 
> 
> Thanks! We could add the fixes tag ...
> 
> Fixes: de3d7018372c dt-bindings: memory: tegra20: emc: Convert to schema

There is no bug here, really. At least no bug with impact, because dtc
won't allow DTS with non-hex numbers.

Best regards,
Krzysztof