linux-kernel - Re: [PATCH] HID: nvidia-shield: Add some null pointer checks to the hid-nvidia-shield.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2401231123050.29548@cbobk.fhfr.pm>
Date: Tue, 23 Jan 2024 11:23:18 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Rahul Rameshbabu <rrameshbabu@...dia.com>
cc: Kunwu Chan <chentao@...inos.cn>, benjamin.tissoires@...hat.com, 
    linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: nvidia-shield: Add some null pointer checks to the
 hid-nvidia-shield.c

On Thu, 18 Jan 2024, Rahul Rameshbabu wrote:

> > devm_kasprintf() returns a pointer to dynamically allocated memory
> > which can be NULL upon failure. Ensure the allocation was successful
> > by checking the pointer validity.
> >
> > Signed-off-by: Kunwu Chan <chentao@...inos.cn>
> > ---
> 
> Just one comment about the subject for future submissions (this one is
> fine). I would just leave the subject as "HID: nvidia-shield: Add some
> null pointer checks". We know what file is being edited from the commit
> content, so the additional filename detail isn't necessary.
> 
> Thanks for the patch. Really appreciate it.
> 
> Reviewed-by: Rahul Rameshbabu <rrameshbabu@...dia.com>

I have tweaked the changelog a little bit and applied, thanks.

-- 
Jiri Kosina
SUSE Labs