[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <089e43c5-1e0e-4c6e-9b91-827b01012b23@intel.com>
Date: Tue, 23 Jan 2024 13:32:19 +0200
From: Adrian Hunter <adrian.hunter@...el.com>
To: Ben Gainey <ben.gainey@....com>, linux-perf-users@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Cc: peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
mark.rutland@....com, alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
namhyung@...nel.org, irogers@...gle.com, will@...nel.org
Subject: Re: [PATCH 0/1] tools: perf: Expose sample ID / stream ID to python
scripts
On 23/01/24 12:31, Ben Gainey wrote:
> This patch modifies the perf python scripting engine so that the ID and
> STREAM_ID are exposed as part of the sample so that they may be
> correlated to the corresponding throttle/unthrottle event (for example).
>
> NB: For scripts where perf_db_export_mode = True, this may be a breaking
> change depending on how the script is constructed. Each field is passed
> to `sample_table` as an argument so any script that is written as:
>
> def sample_table(db_id, evsel_id, machine_id, ..., cyc_cnt, flags)
>
> will now fail due to the changed number of arguments with:
>
> TypeError: sample_table() takes 25 positional arguments but 27 were given
>
> Scripts that use:
>
> def sample_table(*args)
>
> or some variation thereof will not be affected.
That is documented in tools/perf/Documentation/db-export.txt. It was
anticipated that more arguments could be added, so that should be OK.
>
> When `perf_db_export_mode = False`, the script should be unaffected as
> all the arguments are inserted into a dictionary.
>
> The export-to-xxx.py scripts use the (..., *x) form so are not affected.
>
>
> Ben Gainey (1):
> tools: perf: Expose sample ID / stream ID to python scripts
>
> tools/perf/Documentation/perf-script-python.txt | 4 ++--
> tools/perf/util/scripting-engines/trace-event-python.c | 8 +++++++-
> 2 files changed, 9 insertions(+), 3 deletions(-)
>
Powered by blists - more mailing lists