linux-kernel - Re: [PATCH] thunderbolt: Remove usage of the deprecated ida_simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240123113419.GN2543524@black.fi.intel.com>
Date: Tue, 23 Jan 2024 13:34:19 +0200
From: Mika Westerberg <mika.westerberg@...ux.intel.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Andreas Noever <andreas.noever@...il.com>,
	Michael Jamet <michael.jamet@...el.com>,
	Yehezkel Bernat <YehezkelShB@...il.com>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH] thunderbolt: Remove usage of the deprecated
 ida_simple_xx() API

On Mon, Jan 22, 2024 at 06:57:42PM +0100, Christophe JAILLET wrote:
> Le 22/01/2024 à 12:29, Mika Westerberg a écrit :
> > On Thu, Jan 11, 2024 at 10:10:21PM +0100, Christophe JAILLET wrote:
> > > ida_alloc() and ida_free() should be preferred to the deprecated
> > > ida_simple_get() and ida_simple_remove().
> > > 
> > > Note that the upper limit of ida_simple_get() is exclusive, but the one of
> > > ida_alloc_range()/ida_alloc_max() is inclusive. So a -1 has been added
> > > when needed.
> > 
> > Looks tood to me but wanted to check if you tested this on a real
> > hardware or you just build tested?
> > 
> > 
> 
> Hi,
> 
> It was compile tested only.
> 
> Transformation has been done with the help of the cocci script below.

Okay that's what I thought too. I ran some testing on a real hardware
and did not see any issues.

Applied to thunderbolt.git/next, thanks!