linux-kernel - Re: [PATCH] spi: Raise limit on number of chip selects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38630519-733c-4598-97a7-19a5e6306513@sirena.org.uk>
Date: Wed, 24 Jan 2024 14:59:28 +0000
From: Mark Brown <broonie@...nel.org>
To: Jonas Gorski <jonas.gorski@...il.com>
Cc: Guenter Roeck <linux@...ck-us.net>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Herve Codina <herve.codina@...tlin.com>,
	Amit Kumar Mahapatra <amit.kumar-mahapatra@....com>,
	"linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH] spi: Raise limit on number of chip selects

On Wed, Jan 24, 2024 at 02:41:03PM +0100, Jonas Gorski wrote:

> For some reason we don't store neither the actual number of supported
> parallel chipselects in the controller, nor the amount of chipselects
> used by the spi device, so all loops always  need to iterate
> SPI_CS_CNT_MAX times and check for the chipselect numbers not being
> 0xff instead of limiting by the (possible to know) actual number of
> chip selects in use.

Yes, we really can do a lot better here if we keep a bit more data
around.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)