linux-kernel - Re: [PATCH v4 4/8] i3c: svc: Add svc-i3c-main.c and svc-i3c.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 24 Jan 2024 16:59:36 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Frank Li <Frank.Li@....com>
cc: alexandre.belloni@...tlin.com, conor.culhane@...vaco.com, 
    devicetree@...r.kernel.org, 
    Greg Kroah-Hartman <gregkh@...uxfoundation.org>, imx@...ts.linux.dev, 
    Jiri Slaby <jirislaby@...nel.org>, joe@...ches.com, 
    krzysztof.kozlowski+dt@...aro.org, krzysztof.kozlowski@...aro.org, 
    linux-i3c@...ts.infradead.org, LKML <linux-kernel@...r.kernel.org>, 
    linux-serial <linux-serial@...r.kernel.org>, miquel.raynal@...tlin.com, 
    robh@...nel.org, zbigniew.lukwinski@...ux.intel.com
Subject: Re: [PATCH v4 4/8] i3c: svc: Add svc-i3c-main.c and svc-i3c.h

On Tue, 23 Jan 2024, Frank Li wrote:

> SVC i3c is a dual role controller. Move probe() into svc-i3c-main.c. This
> prepares to support target probe depending on dts "mode" settings.
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>  drivers/i3c/master/Makefile         |  3 +-
>  drivers/i3c/master/svc-i3c-main.c   | 52 +++++++++++++++++++++++++++++
>  drivers/i3c/master/svc-i3c-master.c | 34 ++++---------------
>  drivers/i3c/master/svc-i3c.h        | 11 ++++++
>  4 files changed, 71 insertions(+), 29 deletions(-)
>  create mode 100644 drivers/i3c/master/svc-i3c-main.c
>  create mode 100644 drivers/i3c/master/svc-i3c.h
> 
> diff --git a/drivers/i3c/master/Makefile b/drivers/i3c/master/Makefile
> index 3e97960160bc8..484cb81f45821 100644
> --- a/drivers/i3c/master/Makefile
> +++ b/drivers/i3c/master/Makefile
> @@ -2,5 +2,6 @@
>  obj-$(CONFIG_CDNS_I3C_MASTER)		+= i3c-master-cdns.o
>  obj-$(CONFIG_DW_I3C_MASTER)		+= dw-i3c-master.o
>  obj-$(CONFIG_AST2600_I3C_MASTER)	+= ast2600-i3c-master.o
> -obj-$(CONFIG_SVC_I3C_MASTER)		+= svc-i3c-master.o
> +svc-i3c-objs				+= svc-i3c-main.o svc-i3c-master.o
> +obj-$(CONFIG_SVC_I3C_MASTER)		+= svc-i3c.o
>  obj-$(CONFIG_MIPI_I3C_HCI)		+= mipi-i3c-hci/
> diff --git a/drivers/i3c/master/svc-i3c-main.c b/drivers/i3c/master/svc-i3c-main.c
> new file mode 100644
> index 0000000000000..053b2bd9d8317
> --- /dev/null
> +++ b/drivers/i3c/master/svc-i3c-main.c

..

> +module_platform_driver(svc_i3c_master);
> \ No newline at end of file

> diff --git a/drivers/i3c/master/svc-i3c.h b/drivers/i3c/master/svc-i3c.h
> new file mode 100644
> index 0000000000000..0bd1f0112a071
> --- /dev/null
> +++ b/drivers/i3c/master/svc-i3c.h

..

> +#endif
> \ No newline at end of file

Add the trailing newline characters.


-- 
 i.