linux-kernel - Re: [PATCH v1] scsi: ufs: core: Remove the ufshcd_release in ufshcd_err_handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92463403-ea32-4545-a466-21243cd454e2@acm.org>
Date: Wed, 24 Jan 2024 08:17:16 -0800
From: Bart Van Assche <bvanassche@....org>
To: hoyoung seo <hy50.seo@...sung.com>, linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org, alim.akhtar@...sung.com, avri.altman@....com,
 jejb@...ux.ibm.com, martin.petersen@...cle.com, beanhuo@...ron.com,
 kwangwon.min@...sung.com, kwmad.kim@...sung.com, sh425.lee@...sung.com,
 sc.suh@...sung.com, quic_nguyenb@...cinc.com, cpgs@...sung.com,
 grant.jung@...sung.com, junwoo80.lee@...sung.com
Subject: Re: [PATCH v1] scsi: ufs: core: Remove the ufshcd_release in
 ufshcd_err_handling_prepare

On 1/22/24 18:38, hoyoung seo wrote:
> When err_handler is completed, active_reqs becomes negative because
> ufshcd_release() is called again in ufshcd_err_handling_unprepare().
> I tested it while printing the log, and if I misanalyzed it, let me know.

Please repeat your analysis. I think this patch is wrong.

Thanks,

Bart.