linux-kernel - Re: [PATCH] Input: cap11xx - stop using chip ID when configuring it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 24 Jan 2024 17:57:12 +0100
From: Jiri Valek - 2N <jiriv@...s.com>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: cap11xx - stop using chip ID when configuring it

On 1/18/24 18:59, Dmitry Torokhov wrote:
> On Tue, Dec 12, 2023 at 09:33:58PM -0800, Dmitry Torokhov wrote:
>> struct cap11xx_hw_model is supposed to describe the chip capabilities,
>> however later code changes introduced checks against chip ID.
>>
>> Introduce new capabilities in cap11xx_hw_model and use them when applying
>> chip configuration, and remove the enum for chip ID. While at it, rename
>> no_gain to has_gain to match the rest of the new capabilities.
> 
> Jiri, if you could give this a spin on your device that would be great.
> 
> Thanks!
> 
Hi Dmitry,

thanks for changes. Looks good to me.
I verified the functionality on real HW with CAP1293.

Reviewed-by: Jiri Valek - 2N <jiriv@...s.com>