linux-kernel - Re: [PATCH 1/2] dt-bindings: usb: dwc3: Add snps,host-vbus-glitches avoiding vbus glitch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240124-video-lumpiness-178c4e317f5a@spud>
Date: Wed, 24 Jan 2024 17:59:00 +0000
From: Conor Dooley <conor@...nel.org>
To: Frank Li <Frank.li@....com>
Cc: ran.wang_1@....com, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, Felipe Balbi <balbi@...nel.org>,
	"open list:USB SUBSYSTEM" <linux-usb@...r.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, mark.rutland@....com,
	pku.leo@...il.com, sergei.shtylyov@...entembedded.com
Subject: Re: [PATCH 1/2] dt-bindings: usb: dwc3: Add snps,host-vbus-glitches
 avoiding vbus glitch

On Wed, Jan 24, 2024 at 12:47:14PM -0500, Frank Li wrote:
> On Wed, Jan 24, 2024 at 05:36:42PM +0000, Conor Dooley wrote:
> > On Fri, Jan 19, 2024 at 04:31:28PM -0500, Frank Li wrote:
> > > From: Ran Wang <ran.wang_1@....com>
> > > 
> > > When DWC3 is set to host mode by programming register DWC3_GCTL, VBUS
> > > (or its control signal) will turn on immediately on related Root Hub
> > > ports. Then the VBUS will be de-asserted for a little while during xhci
> > > reset (conducted by xhci driver) for a little while and back to normal.
> > > 
> > > This VBUS glitch might cause some USB devices emuration fail if kernel
> > > boot with them connected. One SW workaround which can fix this is to
> > > program all PORTSC[PP] to 0 to turn off VBUS immediately after setting
> > > host mode in DWC3 driver(per signal measurement result, it will be too
> > > late to do it in xhci-plat.c or xhci.c).
> > > 
> > > Signed-off-by: Ran Wang <ran.wang_1@....com>
> > > Reviewed-by: Peter Chen <peter.chen@....com>
> > > Signed-off-by: Frank Li <Frank.Li@....com>
> > > ---
> > >  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > > index 203a1eb66691f..dbf272b76e0b5 100644
> > > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > > @@ -273,6 +273,13 @@ properties:
> > >        with an external supply.
> > >      type: boolean
> > >  
> > > +  snps,host-vbus-glitches:
> > > +    description:
> > > +      When set, power off all Root Hub ports immediately after
> > > +      setting host mode to avoid vbus (negative) glitch happen in later
> > > +      xhci reset. And the vbus will back to 5V automatically when reset done.

nit: "will return to"

> > > +    type: boolean
> > 
> > Why do we want to have a property for this at all? The commit message
> > seems to describe a problem that's limited to specific configurations
> > and appears to be somethng the driver should do unconditionally.
> > 
> > Could you explain why this cannot be done unconditionally please?
> 
> It depends on board design, not all system vbus can be controller by root
> hub port. If it is always on, it will not trigger this issue.

Okay, that seems reasonable to have a property for. Can you add that
info to the commit message please?

On another note, I like it when the property name explains why you would
add it, rather than the thing it is trying to solve.
Named after the disease, rather than the symptoms, if you get me. I
tried to come up with a name here, but could not really suggest
something good. If you can think of something, that'd be good, but don't
stress it.

Thanks,
Conor.


Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)