linux-kernel - Re: [PATCH] gpio: cdev: remove leftover function pointer typedefs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240124234316.GA6255@rigel>
Date: Thu, 25 Jan 2024 07:43:16 +0800
From: Kent Gibson <warthog618@...il.com>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Linus Walleij <linus.walleij@...aro.org>, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] gpio: cdev: remove leftover function pointer typedefs

On Wed, Jan 24, 2024 at 05:17:25PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> The locking wrappers were replaces with lock guards. These typedefs are
> no longer needed.
>

replaced

Given that,

Reviewed-by: Kent Gibson <warthog618@...il.com>

> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> ---
>  drivers/gpio/gpiolib-cdev.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> index 2a88736629ef..34d6712fa07c 100644
> --- a/drivers/gpio/gpiolib-cdev.c
> +++ b/drivers/gpio/gpiolib-cdev.c
> @@ -61,11 +61,6 @@ static_assert(IS_ALIGNED(sizeof(struct gpio_v2_line_values), 8));
>   * interface to gpiolib GPIOs via ioctl()s.
>   */
>
> -typedef __poll_t (*poll_fn)(struct file *, struct poll_table_struct *);
> -typedef long (*ioctl_fn)(struct file *, unsigned int, unsigned long);
> -typedef ssize_t (*read_fn)(struct file *, char __user *,
> -			   size_t count, loff_t *);
> -
>  /*
>   * GPIO line handle management
>   */
> --
> 2.40.1
>